Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge page-title and page-title-list services? #230

Closed
bertdeblock opened this issue Feb 7, 2022 · 3 comments · Fixed by #241
Closed

Merge page-title and page-title-list services? #230

bertdeblock opened this issue Feb 7, 2022 · 3 comments · Fixed by #241

Comments

@bertdeblock
Copy link
Contributor

A while ago, a page-title service was introduced as a means to have a public titleDidUpdate hook,
and also because the entire page-title-list service was/is considered private.
I would like to suggest to have a single page-title service and document what's private and what's public instead.
I think it would make the implementation a little easier and it would make using ember-page-title with engines less awkward,
because at the moment you have to define the name of the page-title-list service to make it work properly: #112 (comment)

@raido
Copy link
Contributor

raido commented Feb 7, 2022

This is doable. Why we didn't do it, when we introduced page-title public service, was because this is a breaking change and it did not seem feasible to bump major in that point of time.

Additionally since this addon is included by default, we need to consider effects of bumping up a major in between minor ember-cli versions.

We should probably begin with deprecations first.

@bertdeblock
Copy link
Contributor Author

Can we include this as part of the v8 release?
I don't think it's worth the time to introduce a deprecation for this.
AFAICT, the only user change that's needed is to rename page-title-list to page-title?

@knownasilya
Copy link
Contributor

@bertdeblock can you submit a pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants