Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies can leak between scenarios #579

Open
ef4 opened this issue Oct 21, 2020 · 4 comments
Open

Dependencies can leak between scenarios #579

ef4 opened this issue Oct 21, 2020 · 4 comments

Comments

@ef4
Copy link
Contributor

ef4 commented Oct 21, 2020

If you have a scenario with no npm section at all, it seems to work, but it silently uses the NPM deps from the previous scenario.

Reproduction:

  1. Clone and yarn install https://github.com/ef4/--try-multi-cli
  2. ember try:each should show a failure.
  3. Uncomment the section in ember-try.js and you will no longer get a failure.

(I created this test app initially because I was trying to confirm that ember-try can really swap the ember-cli version in use -- it can, thanks!)

This seems related to #81 but not identical to it. That older issue seems to imply that this case would be an explicit error, whereas now it seems to be a tolerated-but-faulty.

@kategengler
Copy link
Member

Also described in #451

@rwjblue
Copy link
Member

rwjblue commented Oct 21, 2020

Ya, we need to land the fixes in #451

@ef4
Copy link
Contributor Author

ef4 commented Oct 21, 2020

Thanks. If that definitely covers this, we can close this.

@kategengler
Copy link
Member

kategengler commented Oct 21, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants