Does the {gameType} token work for anyone else?

[samwelnella]

Hello, I'm finding that when I use the {gameType} all games end up in the "Retail" folder including games that have "(Proto)", "(Pirate)" or "(Aftermarket)" in the ROM name. Does anyone else have this issue?

[emmercm]

Hi @samwelnella, this definitely isn't expected. Could you provide some additional information about:

• What DATs you're using, if any
• What some example input files are
• What other options you're using, especially any filtering ones
• What igir version you're using, if it's the most recent version or not

[samwelnella]

Sure my full command is

igir copy extract --dat /srv/mergerfs/PoolFS/Games/DATs/PC\ XML/No-Intro/Nintendo\ -\ Game\ Boy\ Color\ \(Parent-Clone\)\ \(20230907-191751\).dat --input /srv/mergerfs/PoolFS/Games/No-Intro/Nintendo\ -\ Game\ Boy\ Color --output /srv/mergerfs/PoolFS/Games/Organized/gbc/{gameType}/{datReleaseRegion}/ --single --prefer-language EN --prefer-region USA,WORLD,EUR,JPN

I wonder if there's something wrong with my DAT files?

[emmercm]

I would be surprised if it was the DAT, that looks like a fresh download, I'm assuming it's from https://datomatic.no-intro.org/index.php?page=download&op=xml&s=47.

I wonder if your shell is doing some globbing with your output path not being quoted, I'd try quoting that.

Could you provide some checksums of the extracted output files (the path isn't quoted in purpose):

crc32 /srv/mergerfs/PoolFS/Games/Organized/gbc/*/*/*({Proto,Pirate,Aftermarket})* | head -10

[samwelnella]

I am actually using the daily P/C XML DATs from the daily tab here https://datomatic.no-intro.org/index.php?page=download&op=daily&s=47

I tried quoting the paths but I still had the same result.

Here's the result of the crc32 command:

8f3902f2        /srv/mergerfs/PoolFS/Games/Organized/gbc/BIOS/TAI/[BIOS] Genius GB Backup Station (Taiwan) (Unl).gbc
4a5f1e2b        /srv/mergerfs/PoolFS/Games/Organized/gbc/BIOS/TAI/[BIOS] Touch Boy System ROM (Taiwan) (Unl).gbc
59579caa        /srv/mergerfs/PoolFS/Games/Organized/gbc/BIOS/USA/[BIOS] Challenger GB (USA) (Unl).gbc
41884e46        /srv/mergerfs/PoolFS/Games/Organized/gbc/BIOS/USA/[BIOS] Nintendo Game Boy Color Boot ROM (World) (Rev 1).gbc
21524051        /srv/mergerfs/PoolFS/Games/Organized/gbc/Retail/AUS/31-in-1 Mighty Mix (Australia) (31B-001, Sachen) (Unl).gbc
a4ad3678        /srv/mergerfs/PoolFS/Games/Organized/gbc/Retail/CHN/Shuihu Zhuan Zhi Qunmo Fengyun Lu (China) (Unl).gbc
188b06f8        /srv/mergerfs/PoolFS/Games/Organized/gbc/Retail/CHN/Terrifying 911 (China) (En) (Unl).gbc
5046c427        /srv/mergerfs/PoolFS/Games/Organized/gbc/Retail/EUR/Absolute X (Europe) (Proto).gbc
c288e400        /srv/mergerfs/PoolFS/Games/Organized/gbc/Retail/EUR/Action Replay Xtreme - Special Edition for Pokemon Crystal (Europe) (Unl).gbc
d0d3dfed        /srv/mergerfs/PoolFS/Games/Organized/gbc/Retail/EUR/Adventures of the Smurfs, The (Europe) (En,Fr,De,Es,It,Nl).gbc

[emmercm]

I found the issue. I was making the assumption that if a game had any releases it would be "verified" and verified is considered retail. Absolute X has a release, so it's erroneously considered retail:

<game name="Absolute X (Europe) (Proto)">
  <description>Absolute X (Europe) (Proto)</description>
  <release name="Absolute X (Europe) (Proto)" region="EUR"/>
  <rom name="Absolute X (Europe) (Proto).gbc" size="1048576" crc="5046c427" md5="cffbcb83ed97a4ff88f71ee383bd0eba" sha1="34fa9bc6b1fec75751f1f426528f18c833128ff7"/>
</game>

I'll convert this into a bug report and put in the PR.