Fix settings Dictionary #909
Conversation
Raise event for remote servers to update its dictionary. Fixes: 895
lunchin
force-pushed
the
settings-events
branch
from
6902785 to
d675ddb
Compare
|
Hold merge until confirmation fixes issue. |
|
With this implementation we get null for a website setting that had previously changed guid, republishing it helps untill the site is restarted. We changed row 251 to use GetDescendants instead of GetChildren, which solved this particular issue. |
| @@ -192,6 +238,12 @@ public void UpdateSettings(Guid siteId, IContent content, bool isContentNotPubli | |||
| SiteSettings[siteId.ToString() + $"-{contentLanguage}"][contentType] = content; | |||
There was a problem hiding this comment.
shouldn't SiteSettings[$"{siteId}-default"][contentType] = content; be set as well?
There was a problem hiding this comment.
Yes I guess there is case where it already exists in the dictionary
|
I have a working fix, as described here. |
|
@lunchin can you check out my comment #895 (comment) These small changes in the |
|
Adding better implementation |
Raise event for remote servers to update its dictionary.
Fixes: #895