-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break cycles #17
Comments
I don't mind supporting cycles with some extra option, as long as it doesn't affect performance in the main use case (it can be difficult though). Documenting would definitely be helpful. You could try using https://www.npmjs.com/package/cyclical-json but you will need to fork to create stable order for keys. |
I ended up using |
In branch cycles |
would be cool to have this feature! do you consider doing a pull request? |
Comparing two object graphs with cycles sends this library into recursive tail-spin.
Having tested for this issue with both
deep-equal
,fast-deep-equal
anddeep-eql
, I found that the only library where this works, isdeep-eql
, so you might consider referencing their approach.If you don't wish to support object graphs with cycles, perhaps this should be explicitly omitted and noted in the documentation, since it creates pretty serious issues in test-frameworks etc.?
The text was updated successfully, but these errors were encountered: