feat(valid-params): add exclude option
#515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 26 +1
Lines 649 722 +73
Branches 250 280 +30
=========================================
+ Hits 649 722 +73 ☔ View full report in Codecov by Sentry. |
brettz9
force-pushed
the
valid-params-exclude
branch
from
96a66f9
to
9bc56ea
Compare
brettz9
force-pushed
the
valid-params-exclude
branch
from
65b1716
to
8f17361
Compare
scagood
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Code looks good to me
I am not sure of:
- if we want to support off spec uses of promises
- how needed this is anymore
Both bluebird and other promise librarys are deprecating themselves eg:
https://github.com/petkaantonov/bluebird#%EF%B8%8Fnote%EF%B8%8F
https://github.com/kriskowal/q#note
The counter argument (and the reason I approve of this change) is that this is entirely opt-in and fairly simple
brettz9
force-pushed
the
valid-params-exclude
branch
from
8f17361
to
6586ac4
Compare
brettz9
force-pushed
the
valid-params-exclude
branch
from
6586ac4
to
1e13edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Adds an
excludeoption tovalid-params. Allows use of non-standard methods, e.g., Bluebirdcatch.Also refactors a few instances of array join into ES6 templates
Fixes #127