Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-promise-in-callback): add exemptDeclarations option #513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brettz9
Copy link
Member

@brettz9 brettz9 commented Jul 25, 2024

What is the purpose of this pull request?

  • Changes an existing rule

What changes did you make? (Give an overview)

For no-promise-in-callback, add an exemptDeclarations option to prevent reporting when the promise is within function declarations.

Fixes #445

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (57df46a).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #513   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        26    +1     
  Lines          649       698   +49     
  Branches       250       266   +16     
=========================================
+ Hits           649       698   +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettz9 brettz9 requested a review from a team July 25, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive of isInsideCallback for functions with first arg named err/error
1 participant