CI broken due to esp-idf tool 'ninja' extracted as non-executable

[elipsitz]

Following up from here: #479 (comment)

It seems that CI is now broken after a tools update. Manually running the workflow and inspecting the VM, I see that ninja --version fails to run because ninja (the extracted executable) does not have +x permissions.

I suspect this has something to do with changing ninja from a .tar.gz source to a .zip source. Perhaps .tar.gz preserves executable bits, and .zip doesn't.

Here's the relevant bit of esp-idf that extracts zip files:

• https://github.com/espressif/esp-idf/blob/master/tools/idf_tools.py#L526

Here's someone complaining about this issue: https://stackoverflow.com/questions/39296101/python-zipfile-removes-execute-permissions-from-binaries

So this seems to be something that needs to be fixed upstream in esp-idf. Based on tools.json, Ninja is the only tool that uses .zip files on platforms other than Windows.

[elipsitz]

Ah -- it seems someone noticed and fixed this in esp-idf, but the fix is only in esp-idf v5.2: espressif/esp-idf@562bb67

[elipsitz]

I put up a PR against esp-idf to backport this fix: espressif/esp-idf#14633

But perhaps this project should update CI to use v5.2?