Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop data processing when pressing the stop button #179

Open
SkyToGround opened this issue Dec 9, 2018 · 1 comment
Open

Stop data processing when pressing the stop button #179

SkyToGround opened this issue Dec 9, 2018 · 1 comment

Comments

@SkyToGround
Copy link
Contributor

When pressing the stop-button on the screen shown in the attached image, it can sometimes take minutes for data processing to actually stop. My guess is that the code only checks for a stop-condition after having processed the currently available kafka messages. This should be changed so that the stop condition is checked in every iteration of the processing loop.
screenshot

@martukas
Copy link
Collaborator

martukas commented Dec 9, 2018

Your assumptions are not quite correct. It tries to stop as soon as it can.
If there is lag, it's likely because it has trouble keeping up with either parsing or histogramming. You can mitigate this in two ways, both of which are in the config tree on the DAQ tab.

  1. In ESSStream you can tell it to FF to most recent kafka messages, which will mitigate any lag in parsing
  2. You can tell it to drop spills (top level), which will allow it to skip histogramming some data.

This, of course, will mean that you won't get a totally honest representation of the data, but I am guessing you will analyze it later from the written h5 files. For instantaneous live monitoring it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants