Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Phabricator webhooks? #68

Open
tudor opened this issue Mar 29, 2018 · 1 comment
Open

Support for Phabricator webhooks? #68

tudor opened this issue Mar 29, 2018 · 1 comment

Comments

@tudor
Copy link

tudor commented Mar 29, 2018

It seems Phabulous only supports the (old-style) feed.http-hooks hooks, which are unauthenticated and go over http (not https).

This works fine when running your own Phabricator instance on the same host as Phabulous (you make Phabulous listen only on localhost and make Phabricator connect to localhost:XXXX) but not when using a (Phacility or otherwise) hosted Phabricator instance: the POST request from Phabricator would go through http (not https) over the public Internet; also Phabulous cannot authenticate that it came from the right place.

In February 2018, Phabricator added webhooks, which are hashed with a secret shared between Phabricator and the webhook: https://secure.phabricator.com/book/phabricator/article/webhooks/ (This is similar to Github's webhooks: https://developer.github.com/webhooks/securing/)

Are there any plans to add support for Phabricator webhooks to Phabulous?

@schemar
Copy link
Collaborator

schemar commented Apr 3, 2018

Thank you for bringing this to my attention @tudor!

I would love to have this in phabulous, but I have very limited time at the moment.
It would be awesome if someone created a pull request ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants