Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for a tagged version #97

Open
mpe85 opened this issue Dec 19, 2021 · 5 comments
Open

Plans for a tagged version #97

mpe85 opened this issue Dec 19, 2021 · 5 comments

Comments

@mpe85
Copy link

mpe85 commented Dec 19, 2021

First of all, thanks for all the work done so far on this great library.
Are there any plans to publish a tagged version, like discribed here https://go.dev/blog/publishing-go-modules?

@kortschak
Copy link
Member

There are no plans, but I'm not wedded to working on pseudo semver. If there is a good reason to move to tagged versioning I'm happy to do that.

@mpe85
Copy link
Author

mpe85 commented Dec 19, 2021

As soon as the API is stable it makes sense to tag a v1.0.0, and if in some future you decide to break the API you could tag a v2.0.0.
This way it would be easier for people to see if an upgrade, e.g. from 1.0.0 to 1.0.1, does not break the API and its safe to upgrade. Besides that it's also easier to reference a tagged version in one's go.mod file.
With those pseude version numbers v0.0.0-xxx you never know what you get when doing an upgrade without having to look at the source code of the project.

I think it's not really much effort since you only have to create a git tag and push to github.

@kortschak
Copy link
Member

In theory, that's how it works, but modules versions >1 are irritating. I'd be happy to tag at v0.1.0. I don't anticipate breaking changes, but I don't have the time to deal with v2 modules if they do happen.

@mpe85
Copy link
Author

mpe85 commented Dec 19, 2021

Sure, it's totally up to you how to handle this. A v0.1.0 tag would at least help to better integrate with golang modules.

@kortschak
Copy link
Member

I'll see when I have time to do that. Probably when I update the tested versions. It's worth noting that the ev3go packages have been opted into modules for a few years now and pseudo versions are perfectly legitimate way to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants