Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download TODO comment: handle non 200 response for individual solution files #794

Open
jdsutherland opened this issue Jan 20, 2019 · 1 comment
Open

download TODO comment: handle non 200 response for individual solution files #794

jdsutherland opened this issue Jan 20, 2019 · 1 comment

Comments

@jdsutherland
Copy link
Contributor

jdsutherland commented Jan 20, 2019 •
edited
Loading

In effort to resolve TODO comments, I'm in the process of promoting them to issues.

cli/cmd/download.go

Lines 189 to 190 in a86f829

if res.StatusCode != http.StatusOK {
// TODO: deal with it

Currently, non 200 responses are swallowed. Do we know how we want to handle this?
@jdsutherland jdsutherland changed the title download: handle non 200 response download TODO comment: handle non 200 response for individual solution files Jan 20, 2019
@kytrinyx
Copy link
Member

Let's error out and display the message from the API, if there is one.

jdsutherland added a commit to jdsutherland/cli that referenced this issue Feb 20, 2019
@jdsutherland
Download non-200 response no longer swallowed
7350455 
Based on exercism#794, we've decide to
error out and display API error messages.

This overlaps with cmd/submit, so this change extracts it for sharing.
jdsutherland added a commit to jdsutherland/cli that referenced this issue Feb 21, 2019
@jdsutherland
Download non-200 response no longer swallowed
f0f6424 
Based on exercism#794, we've decide to
error out and display API error messages.

This overlaps with cmd/submit, so this change extracts it for sharing.
jdsutherland added a commit to jdsutherland/cli that referenced this issue Feb 21, 2019
@jdsutherland
Download non-200 response no longer swallowed
79a3906 
Based on exercism#794, we've decide to
error out and display API error messages.

This overlaps with cmd/submit, so this change extracts it for sharing.
jdsutherland added a commit to jdsutherland/cli that referenced this issue Feb 21, 2019
@jdsutherland
Download non-200 response no longer swallowed
92aa279 
Based on exercism#794, we've decide to
error out and display API error messages.

This overlaps with cmd/submit, so this change extracts it for sharing.
jdsutherland added a commit to jdsutherland/cli that referenced this issue Feb 21, 2019
@jdsutherland
Download non-200 response no longer swallowed
c934fc6 
Based on exercism#794, we've decide to
error out and display API error messages.

This overlaps with cmd/submit, so this change extracts it for sharing.
jdsutherland added a commit to jdsutherland/cli that referenced this issue Feb 22, 2019
@jdsutherland
Download non-200 response no longer swallowed
738f5f5 
Based on exercism#794, we've decide to
error out and display API error messages.

This overlaps with cmd/submit, so this change extracts it for sharing.
jdsutherland added a commit to jdsutherland/cli that referenced this issue Feb 22, 2019
@jdsutherland
Download non-200 response no longer swallowed
f87b49c 
Based on exercism#794, we've decide to
error out and display API error messages.

This overlaps with cmd/submit, so this change extracts it for sharing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kytrinyx @jdsutherland