Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run environment fields to Result object #1521

Open
onmyraedar opened this issue Jan 23, 2025 · 2 comments
Open

Add run environment fields to Result object #1521

onmyraedar opened this issue Jan 23, 2025 · 2 comments
Assignees

Comments

@onmyraedar
Copy link
Collaborator

  • Adding the key source would help us determine if the correct custodial key was used
  • We could also note when/where the job was run
@johnjosephhorton
Copy link
Contributor

Thanks @onmyraedar - so right now, this is what the config looks like (before it's populated):

RunConfig(environment=RunEnvironment(cache=None, bucket_collection=None, key_lookup=None, jobs_runner_status=None), parameters=RunParameters(n=1, progress_bar=False, stop_on_exception=False, check_api_keys=False, verbose=True, print_exceptions=True, remote_cache_description=None, remote_inference_description=None, remote_inference_results_visibility='unlisted', skip_retry=False, raise_validation_errors=False, disable_remote_cache=False, disable_remote_inference=True, job_uuid=None))

Adding the timestamp is easy. But writing in the keys directly (from keylookup) obviously isn't a good idea. What would be most useful? I could make, say, KeyLookup hashable...

@onmyraedar
Copy link
Collaborator Author

Hashing works (on the devops side at least).

Something human-readable might also be nice - the LanguageModelInput from the KeyLookup also has a token_source that could be helpful? On the Coop side, I'm populating that field with a short descriptive string like "shared_custodial_key", "api_key", etc. that tells you a little more about where the key came from (even if it doesn't point you to the exact key).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants