-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated substr() with slice() in the codebase #110
Comments
if it is still open, can I try to work on this? |
Hey @gitdevjin 👋 It appears we have a open PR for this one already. Could you please review the PR if you are interested? #111 |
@IamLizu |
@gitdevjin Thanks for reviewing my pull request. Actually, I only created the PR post creating this issue thread. @IamLizu Thank you for your review and approval. The pull request is now ready for merging. Please proceed if there are no additional concerns or outstanding issues. |
Summary
The
substr()
method is deprecated in JavaScript and may cause issues or warnings in future versions. To ensure better compatibility and prevent potential runtime issues, we should replace all occurrences ofsubstr()
withslice()
.Details
Currently, the following functions in
index.js
file contain instances ofsubstr()
:These should be refactored to use
slice()
instead.Why It Should Be Fixed
JavaScript's
substr()
method has been deprecated. Refactoring to useslice()
will future-proof the code and prevent potential issues in modern JavaScript environments. This change is necessary for compatibility with new ECMAScript standards and best practices.Suggested Solution
Replace
substr()
withslice()
in all occurrences.References
For more details on the deprecation of
substr()
, see the MDN documentation: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substrThe text was updated successfully, but these errors were encountered: