Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-hooks fail #2482

Open
Joshix-1 opened this issue Jan 15, 2025 · 0 comments · May be fixed by #2483
Open

git-hooks fail #2482

Joshix-1 opened this issue Jan 15, 2025 · 0 comments · May be fixed by #2483
Labels
bug Something isn't working

Comments

@Joshix-1
Copy link
Contributor

Joshix-1 commented Jan 15, 2025

Describe the bug
env SHELL=cat git commit -m "test" runs git-hooks correctly, but gitui with a nonstandard shell doesn't

To Reproduce
0. go to repo with pre-commit hooks

  1. env SHELL=cat gitui
  2. create a commit
  3. See error
  4. see that env SHELL=cat git commit -m "test" works

Expected behavior
git-hooks should work even with a non-standard shell.

Screenshots
image

Context (please complete the following information):

  • OS/Distro + Version: [e.g. macOS 10.15.5] Linux
  • GitUI Version [e.g. 0.5] v0.27.0
  • Rust version: [e.g 1.44] 1.83.0

Additional context
Add any other context about the problem here.
I think /bin/sh or git var GIT_SHELL_PATH should be used.
#2343 (comment)
We should probably do the same as in: GitoxideLabs/gitoxide@51bbb86

While this issue is a bit constructed, with SHELL=xonsh i have the problem that my pre-commit hooks do not get run. So this is a real problem users could be facing.

@Joshix-1 Joshix-1 added the bug Something isn't working label Jan 15, 2025
@Joshix-1 Joshix-1 linked a pull request Jan 15, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant