Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setVisibleSize deprecated #14

Open
valeonte opened this issue Apr 5, 2022 · 1 comment
Open

setVisibleSize deprecated #14

valeonte opened this issue Apr 5, 2022 · 1 comment

Comments

@valeonte
Copy link

valeonte commented Apr 5, 2022

Hi
First of all, excellent work and thank you for sharing! I've been looking for something like this for a while now, and I'll start building my project around that.

"setVisibleSize" is running every time you instantiate a ChromeContext, would you consider making that optional? Apart from the fact that it is deprecated, in most of my use cases I wouldn't want to have that running.

If you agree, happy to put in a pull request.

Thank you!

@fake-name
Copy link
Owner

fake-name commented Apr 6, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants