Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable gen test #1121

Open
guybedford opened this issue Feb 15, 2025 · 2 comments
Open

Reenable gen test #1121

guybedford opened this issue Feb 15, 2025 · 2 comments
Assignees

Comments

@guybedford
Copy link
Member

guybedford commented Feb 15, 2025

I had to disable the generation insert test in #1120 because it is consistently failing.

We should investigate the root cause here and reenable the test to be sure the functionality is working correctly.

/cc @vcarvajal-sigsci

@guybedford
Copy link
Member Author

Specifically, kv.lookup() should be able to get the generation integer I think, and then that is the integer that should be used on insertion to avoid double insertion. So we might have a misuse of the API.

Alternatively we may have a KV bug either in our implementation or otherwise that this isn't working correctly - either way it needs to be investigated.

@vcarvajal-sigsci vcarvajal-sigsci self-assigned this Feb 15, 2025
@guybedford
Copy link
Member Author

I think we might need a kv.lookupWithGeneration since the existing lookup doesn't return the generation integer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants