Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use event loop for data transfer #20

Open
IlyaBizyaev opened this issue Apr 22, 2017 · 2 comments
Open

Use event loop for data transfer #20

IlyaBizyaev opened this issue Apr 22, 2017 · 2 comments

Comments

@IlyaBizyaev
Copy link
Collaborator

HTTPFileServer is not as Qt friendly as we want it to be: it uses a loop that blocks signal processing and makes big files cause a crash on Windows.

What is not a solution: flush(), waitForBytesWritten(), QCoreApplication::processEvents()
Solution: signals and slots, as most of QTcpSockets' functionality is implemented as those.

See http://doc.qt.io/qt-5/qabstractsocket.html#flush and http://doc.qt.io/qt-5/qabstractsocket.html#waitForBytesWritten for reference.

@IlyaBizyaev
Copy link
Collaborator Author

Another problem our loop introduces is that multiple renderers cannot be used in parallel.

@IlyaBizyaev
Copy link
Collaborator Author

IlyaBizyaev commented Apr 22, 2017

Also, seek is not possible if the renderer prefers parallel requests (e.g. Kodi on Windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant