Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing keyword await for the set_with_merge.js file #330

Open
waldothedeveloper opened this issue Mar 3, 2023 · 1 comment
Open

missing keyword await for the set_with_merge.js file #330

waldothedeveloper opened this issue Mar 3, 2023 · 1 comment

Comments

@waldothedeveloper
Copy link

The docs related to Set a document see here are missing the keyword await before setDoc() function.
For the code example where the { merge: true} is used.

image

All of the previous and subsequent code snippets do contain the word await for the setDoc() function. Does the {merge: true} change the async behavior of the setDoc() function?

If not, the await should be present in that snippet to match all of the other code snippets for this page.

Here's another example on the same page where the await keyword is present for the setDoc() function:

image

@waldothedeveloper
Copy link
Author

I can submit a PR if needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant