Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UNC paths on Windows #1131

Open
bryanpkc opened this issue Sep 7, 2021 · 0 comments
Open

Support UNC paths on Windows #1131

bryanpkc opened this issue Sep 7, 2021 · 0 comments
Labels
windows Add this to all windows specific issues or PRs

Comments

@bryanpkc
Copy link
Collaborator

bryanpkc commented Sep 7, 2021

From #1127 (comment):

[Flang is] missing support for UNC paths like \machine\mountpoint\file, which to my best knowledge are mainly used when files on a non-local drive are to be referenced (network drives).

See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths for some more information.

Please also note that this documentation might give the impression that a path like \example is considered absolute. This is usually not true as far as I know. E.g. both PathIsRelative from the Windows API as well as std::filesystem::path::is_relative with Microsofts STL implementation will return true for such a path. (To my understanding it is absolute to the current drive, but not fully qualified since the drive is not specified.)

Not sure whether you want to apply the necessary changes in this PR or whether you prefer to merge the current, partial support and open an issue for the remaining UNC path detection.

@isuruf isuruf added the windows Add this to all windows specific issues or PRs label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Add this to all windows specific issues or PRs
Projects
None yet
Development

No branches or pull requests

2 participants