Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting metadata value with a secret/variable fails in the end_user_authentication section #26135

Open
allenhouchins opened this issue Feb 6, 2025 · 3 comments
Assignees
Labels
bug Something isn't working as documented #g-orchestration Orchestration product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.

Comments

@allenhouchins
Copy link
Member

Fleet version: 4.63
Web browser and operating system: Any


💥  Actual behavior

I am trying to set a value for metadata via gitops for end_user_authentication using a github secret (ex: $DOGFOOD_SSO_METADATA). This results in the error:Error: failed to unmarshal file error converting YAML to JSON: yaml: line 42: could not find expected ':':

This same secret works without issue under the sso_settings option. I am also able to get the end_user_authentication section to work if I paste the contents of that variable as the value (as a string). This issue seems limited to some validation we are doing specifically in the end_user_authentication section. Setting the values through the UI gives me expected results.

🧑‍💻  Steps to reproduce

  1. Grab the XML Single sign-on metadata out of dogfood
  2. Set it as a variable and pass it to the metadata field under end_user_authentication
  3. Observe error

🕯️ More info (optional)

See this pull request for the error: #26042

@allenhouchins allenhouchins added :incoming New issue in triage process. :reproduce Involves documenting reproduction steps in the issue bug Something isn't working as documented labels Feb 6, 2025
@allenhouchins allenhouchins added :product Product Design department (shows up on 🦢 Drafting board) #g-orchestration Orchestration product group ~released bug This bug was found in a stable release. and removed :reproduce Involves documenting reproduction steps in the issue labels Feb 6, 2025
@rachaelshaw rachaelshaw removed the :incoming New issue in triage process. label Feb 6, 2025
@sharon-fdm sharon-fdm removed their assignment Feb 10, 2025
@sharon-fdm
Copy link
Collaborator

@sgress454
Copy link
Contributor

I wouldn't be surprised if this was due to the contents of the variable, rather than an issue with using a variable for this config.

@sharon-fdm sharon-fdm added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed :product Product Design department (shows up on 🦢 Drafting board) labels Feb 10, 2025
@sgress454
Copy link
Contributor

@allenhouchins can you DM and let me know how you're setting the env var when testing #26042?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented #g-orchestration Orchestration product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Projects
None yet
Development

No branches or pull requests

4 participants