BUG: Activity Report: Sessions Held not calculating correctly.

[ttlenard]

Describe the Bug
A clear and concise description of what the bug is.

It seems if a session is unassigned to a Judge, the session is getting added to the Sessions Held counts for all judges on the Activity report. I found this by doing some tests with a judge that was just created in story 10455. When I pulled the activity report for the new judge, I noticed that there were special sessions and a Motion Hearing assigned to her. After looking into it more, Christopher was able to confirm that unassigned sessions are getting counted for all judges. I was able to confirm this by pulling the statistics activity report for multiple judges, and all of the judges also had these sessions in their "Sessions Held" count.

Another (minor) issue that I found was that the sessions held section was pulling in sessions that started tomorrow. From Christopher, "Looking at the code slightly more confirms my suspicion that the "off-by-one" error is a timezone thing. I'm not sure how easy that is to fix: the client "today" might be different than the server "today"."

Business Impact/Reason for Severity
medium

In which environment did you see this bug?
Test, Staging

Who were you logged in as?
Judge users

What were you doing when you discovered this bug? (Using the application, demoing, smoke tests, testing other functionality, etc.)
I was testing other functionality when I found this issue.

To Reproduce
Steps to reproduce the behavior:

1. Log in as a test judge user (I was testing with a brand new judge created for testing 10455)
2. Click on Reports and then select Activity
3. Input today's date for the end date, and put in a date somewhat close (like a 2 week period?) (I put 9/1/24 - 9/16/24)
4. Click View Statistics
5. Notice that the new judge shows that they had 2 special sessions and 0.5 Motion hearings.
6. If you look at the Trial sessions page for this time frame, you'll see that there were 2 specials and 1 motion/hearing that are unassigned on TEST. These are getting into the Count of any judges Sessions held section on the Activity report and they shouldn't be.
7. Also - it appears that sessions that I created for tomorrow are showing in the sessions held section. This probably only happens when I view this in the late afternoon due to time zone differences?

Expected Behavior
A clear and concise description of what you expected to happen.
Unassigned sessions shouldn't be getting counted for selected Judges in the Activity report. Sessions that start tomorrow should not show in the sessions held when I run the report.

Actual Behavior
A clear and concise description of what actually happened.
Unassigned trial sessions are getting counted for ANY judge that runs the report with those sessions in the time-frame they run the report for. Sessions that start tomorrow are showing in the sessions held when I run the report

Screenshots
If applicable, add screenshots to help explain your problem.

New judge - showing 2 specials and a motion/hearing

Here are the unassigned special sessions:

Here is the unassigned Motion/hearing:

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Cause of Bug, If Known

Process for Logging a Bug:

• Complete the above information
• Add a severity tag (Critical, High Severity, Medium Severity or Low Severity). See below for priority definition.

Severity Definition:

• Critical Defect
  Blocks entire system's or module’s functionality
  No workarounds available
  Testing cannot proceed further without bug being fixed.

• High-severity Defect
  Affects key functionality of an application
  There's a workaround, but not obvious or easy
  App behaves in a way that is strongly different from the one stated in the requirements

• Medium-severity Defect
  A minor function does not behave in a way stated in the requirements.
  Workaround is available and easy

• Low-severity Defect
  Mostly related to an application’s UI
  Doesn't need a workaround, because it doesn't impact functionality

Definition of Ready for Bugs(Created 10-4-21)

Definition used: A failure or flaw in the system which produces an incorrect or undesired result that deviates from the expected result or behavior. (Note: Expected results are use cases that have been documented in past user stories as acceptance criteria and test cases, and do not include strange behavior unrelated to use cases.)

The following criteria must be met in order for the development team to begin work on the bug.

The bug must:

• Be focused on solving a user problem
• Contain data for all fields in the bug template, so the team can pick it up and begin working immediately

Process: If the unexpected results are new use cases that have been identified, but not yet built, new acceptance criteria and test cases should be captured in a new user story and prioritized by the product owner.

If the Court is not able to reproduce the bug, add the “Unable to reproduce” tag. This will provide visibility into the type of support that may be needed by the Court. In the event that the Court cannot reproduce the bug, the Court will work with Flexion to communicate what type of troubleshooting help may be needed.

Definition of Done (Updated 4-14-21)

Product Owner

• Bug fix has been validated in the Court's test environment

Engineering

• Automated test scripts have been written
• Field level and page level validation errors (front-end and server-side) integrated and functioning
• Verify that language for docket record for internal users and external users is identical
• New screens have been added to pa11y scripts
• All new functionality verified to work with keyboard and macOS voiceover https://www.apple.com/voiceover/info/guide/_1124.html
• READMEs, other appropriate docs and swagger/APIs fully updated
• UI should be touch optimized and responsive for external only (functions on supported mobile devices and optimized for screen sizes as required)
• Interactors should validate entities before calling persistence methods
• Code refactored for clarity and to remove any known technical debt
• Deployed to the Court's test environment if prod-like data is required. Otherwise, deployed to any experimental environment for review.