Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override gr_mat_eigenvalues #1992

Open
fredrik-johansson opened this issue May 20, 2024 · 1 comment
Open

Override gr_mat_eigenvalues #1992

fredrik-johansson opened this issue May 20, 2024 · 1 comment

Comments

@fredrik-johansson
Copy link
Collaborator

Currently gr_mat_diagonalization can be overridden by rings but gr_mat_eigenvalues just has a default algorithm.
@fredrik-johansson
Copy link
Collaborator Author

Two related problem which I'm too lazy to create a new issue for right now: gr_mat_diagonalization currently computes the R matrix by linear solving, then inverts R to obtain L. It is probably better (in terms of numerical stability or intermediate expression swell, where applicable) to do an independent linear solve for L. Also, the calculations can be simplified when all eigenvalues have multiplicity 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fredrik-johansson