From 60b4adf3534602c53c77fe0f91e3d87d66e5f473 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Fri, 21 Jun 2024 18:12:27 +0800
Subject: [PATCH 01/23] inseart new test file

---
 .../janitor/generate-link-references.test.ts  |  2 +-
 .../file-with-different-link-formats.md       | 21 +++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 packages/foam-vscode/test-data/__scaffold__/file-with-different-link-formats.md

diff --git a/packages/foam-vscode/src/core/janitor/generate-link-references.test.ts b/packages/foam-vscode/src/core/janitor/generate-link-references.test.ts
index 708f4be4c..eaebf7cc5 100644
--- a/packages/foam-vscode/src/core/janitor/generate-link-references.test.ts
+++ b/packages/foam-vscode/src/core/janitor/generate-link-references.test.ts
@@ -36,7 +36,7 @@ describe('generateLinkReferences', () => {
   });
 
   it('initialised test graph correctly', () => {
-    expect(_workspace.list().length).toEqual(10);
+    expect(_workspace.list().length).toEqual(11);
   });
 
   it('should add link references to a file that does not have them', async () => {
diff --git a/packages/foam-vscode/test-data/__scaffold__/file-with-different-link-formats.md b/packages/foam-vscode/test-data/__scaffold__/file-with-different-link-formats.md
new file mode 100644
index 000000000..3ba8e9e74
--- /dev/null
+++ b/packages/foam-vscode/test-data/__scaffold__/file-with-different-link-formats.md
@@ -0,0 +1,21 @@
+# File with different link formats
+
+markdown link [home page](https://foambubble.github.io/)
+
+wikilink to file [[first-document]].
+
+markdown format link to local [file](first-document.md)
+
+embeded wikilink to file ![[second-document]].
+
+wikilink to placeholder [[non-exist-file]]
+
+in-note anchor [[file-with-different-link-formats#one section]]
+
+alias to anchor [[file-with-different-link-formats#one section|another name]]
+
+alias [[first-document|an alias]]
+
+dupilcated wikilink to file [[first-document]]
+
+# one section
\ No newline at end of file

From bab6cd7327e350de91f9943e52b8acab5171569c Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Fri, 21 Jun 2024 18:17:23 +0800
Subject: [PATCH 02/23] add generate standalone note command

---
 .../src/core/janitor/generate-mdlinks.test.ts |  55 +++++++++
 .../src/core/janitor/generate-mdlinks.ts      | 107 ++++++++++++++++++
 .../foam-vscode/src/core/janitor/index.ts     |   1 +
 .../commands/generate-standalone-note.ts      |  73 ++++++++++++
 .../src/features/commands/index.ts            |   1 +
 5 files changed, 237 insertions(+)
 create mode 100644 packages/foam-vscode/src/core/janitor/generate-mdlinks.test.ts
 create mode 100644 packages/foam-vscode/src/core/janitor/generate-mdlinks.ts
 create mode 100644 packages/foam-vscode/src/features/commands/generate-standalone-note.ts

diff --git a/packages/foam-vscode/src/core/janitor/generate-mdlinks.test.ts b/packages/foam-vscode/src/core/janitor/generate-mdlinks.test.ts
new file mode 100644
index 000000000..ad8a5af1a
--- /dev/null
+++ b/packages/foam-vscode/src/core/janitor/generate-mdlinks.test.ts
@@ -0,0 +1,55 @@
+import { generateMarkdownLinks } from './generate-mdlinks';
+import { TEST_DATA_DIR } from '../../test/test-utils';
+import { MarkdownResourceProvider } from '../services/markdown-provider';
+import { Resource } from '../model/note';
+import { FoamWorkspace } from '../model/workspace';
+import { Logger } from '../utils/log';
+import fs from 'fs';
+import { URI } from '../model/uri';
+import { createMarkdownParser } from '../services/markdown-parser';
+import { FileDataStore } from '../../test/test-datastore';
+
+Logger.setLevel('error');
+
+describe('generateStdMdLink', () => {
+  let _workspace: FoamWorkspace;
+  // TODO slug must be reserved for actual slugs, not file names
+  const findBySlug = (slug: string): Resource => {
+    return _workspace
+      .list()
+      .find(res => res.uri.getName() === slug) as Resource;
+  };
+
+  beforeAll(async () => {
+    /** Use fs for reading files in units where vscode.workspace is unavailable */
+    const readFile = async (uri: URI) =>
+      (await fs.promises.readFile(uri.toFsPath())).toString();
+    const dataStore = new FileDataStore(
+      readFile,
+      TEST_DATA_DIR.joinPath('__scaffold__').toFsPath()
+    );
+    const parser = createMarkdownParser();
+    const mdProvider = new MarkdownResourceProvider(dataStore, parser);
+    _workspace = await FoamWorkspace.fromProviders([mdProvider], dataStore);
+  });
+
+  it('initialised test graph correctly', () => {
+    expect(_workspace.list().length).toEqual(11);
+  });
+
+  it('can generate markdown links correctly', async () => {
+    const note = findBySlug('file-with-different-link-formats');
+    const actual = await generateMarkdownLinks(note, _workspace);
+    const expected: string[] = [
+      '[first-document](first-document.md "First Document")',
+      '[second-document](second-document.md "Second Document")',
+      '[#one section](<#one section> "File with different link formats")',
+      '[another name](<#one section> "File with different link formats")',
+      '[an alias](first-document.md "First Document")',
+    ];
+    expect(actual.length).toEqual(expected.length);
+    const _ = actual.map((textReplace, index) => {
+      expect(textReplace.to).toEqual(expected[index]);
+    });
+  });
+});
diff --git a/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts b/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts
new file mode 100644
index 000000000..3cc6ed395
--- /dev/null
+++ b/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts
@@ -0,0 +1,107 @@
+import { NoteLinkDefinition, Resource } from '../model/note';
+import { FoamWorkspace } from '../model/workspace';
+import { createMarkdownReferences } from '../services/markdown-provider';
+
+export interface TextReplace {
+  from: string;
+  to: string;
+}
+
+/**
+ * parse wikilink's rawText
+ * possible inpout:
+ *  1. [[\<filename\>#\<section\>|\<label\>]]
+ *  2. [[#\<section\>|\<label\>]]
+ *  3. [[\<filename\>#\<section\>]]
+ *  4. [[\<filename\>|\<label\>]]
+ */
+class WikilinkRawText {
+  private lable_m: string = '';
+  private filename_m: string = '';
+  private section_m: string = '';
+
+  public readFromText(definition: NoteLinkDefinition): WikilinkRawText {
+    const struct_rawText_regex =
+      /(?:(?<filename>[^\]|#]+)?(?:#(?<section>[^\]|]+))?)?(?:\|(?<label>[^\]]+))?/;
+    const match_result = definition.label.match(struct_rawText_regex);
+    if (match_result) {
+      this.filename_m = match_result[1];
+      this.section_m = match_result[2];
+      this.lable_m = match_result[3];
+    }
+    return this;
+  }
+
+  public getLable(): string {
+    if (this.lable_m) {
+      return this.lable_m;
+    }
+    // return `${this.getFilename()}${this.section_m ? '#' : ''}${this.getSection()}`;
+    return '';
+  }
+  public getFilename(): string {
+    if (this.filename_m) {
+      return this.filename_m;
+    }
+    return '';
+  }
+  public getSection(): string {
+    if (this.section_m) {
+      return this.section_m;
+    }
+    return '';
+  }
+  public toMarkdownLink(
+    definition: NoteLinkDefinition,
+    toNote: Resource
+  ): string {
+    const struct_rawText_regex =
+      /(?:(?<filename>[^\]|#]+)?(?:#(?<section>[^\]|]+))?)?(?:\|(?<label>[^\]]+))?/;
+    const match_result = definition.label.match(struct_rawText_regex);
+    this.filename_m = match_result[1];
+    this.section_m = match_result[2];
+    this.lable_m = match_result[3];
+
+    let url = `${
+      definition.url !== toNote.uri.getBasename() ? definition.url : ''
+    }${this.section_m ? `#${this.getSection()}` : ''}`;
+    if (url.indexOf(' ') > 0) {
+      url = `<${url}>`;
+    }
+    url = `(${url}${definition.title ? ` "${definition.title}"` : ''})`;
+
+    let label = this.lable_m;
+    let filename =
+      this.getFilename() !== toNote.uri.getName() ? this.getFilename() : '';
+    let section = this.getSection();
+    if (!label) {
+      label = `${filename}${this.section_m ? `#${section}` : ''}`;
+    }
+
+    return `[${label}]${url}`;
+  }
+}
+
+export const generateMarkdownLinks = async (
+  note: Resource,
+  workspace: FoamWorkspace
+): Promise<TextReplace[]> => {
+  if (!note) {
+    return [] as TextReplace[];
+  }
+
+  const newWikilinkDefinitions = createMarkdownReferences(
+    workspace,
+    note,
+    true
+  );
+  const wikilinkRawTextParser = new WikilinkRawText();
+  const toReplaceArray = newWikilinkDefinitions.map(definition => {
+    return {
+      from: `[[${definition.label}]]`,
+      to: wikilinkRawTextParser.toMarkdownLink(definition, note),
+    };
+  });
+
+  return toReplaceArray;
+};
diff --git a/packages/foam-vscode/src/core/janitor/index.ts b/packages/foam-vscode/src/core/janitor/index.ts
index bded3032d..bcebfa984 100644
--- a/packages/foam-vscode/src/core/janitor/index.ts
+++ b/packages/foam-vscode/src/core/janitor/index.ts
@@ -1,2 +1,3 @@
 export { generateLinkReferences } from './generate-link-references';
 export { generateHeading } from './generate-headings';
+export { generateMarkdownLinks } from './generate-mdlinks';
diff --git a/packages/foam-vscode/src/features/commands/generate-standalone-note.ts b/packages/foam-vscode/src/features/commands/generate-standalone-note.ts
new file mode 100644
index 000000000..4084c6c1d
--- /dev/null
+++ b/packages/foam-vscode/src/features/commands/generate-standalone-note.ts
@@ -0,0 +1,73 @@
+import { commands, ExtensionContext, window } from 'vscode';
+import { isMdEditor } from '../../utils';
+import { Foam } from '../../core/model/foam';
+import { FoamWorkspace } from '../../core/model/workspace';
+import { fromVsCodeUri } from '../../utils/vsc-utils';
+import { getEditorEOL } from '../../services/editor';
+import { ResourceParser } from '../../core/model/note';
+import { IMatcher } from '../../core/services/datastore';
+import { generateMarkdownLinks } from '../../core/janitor';
+const vscode = require('vscode'); /* cannot import workspace from above statement and not sure what happened */
+
+export default async function activate(
+  context: ExtensionContext,
+  foamPromise: Promise<Foam>
+) {
+  const foam = await foamPromise;
+
+  context.subscriptions.push(
+    commands.registerCommand('foam-vscode.generate-standalone-note', () => {
+      return generateStandaloneNote(
+        foam.workspace,
+        foam.services.parser,
+        foam.services.matcher
+      );
+    })
+  );
+}
+
+/**
+ * based on generate-link-references,
+ * copy the current note,
+ * replace wikilinks in it,
+ * save it at the same directory,
+ * call update-wikilinks to remove link references if neccessary
+ */
+async function generateStandaloneNote(
+  fWorkspace: FoamWorkspace,
+  fParser: ResourceParser,
+  fMatcher: IMatcher
+) {
+  const editor = window.activeTextEditor;
+  const doc = editor.document;
+
+  if (!isMdEditor(editor) || !fMatcher.isMatch(fromVsCodeUri(doc.uri))) {
+    return;
+  }
+
+  // const setting = getWikilinkDefinitionSetting();
+  const eol = getEditorEOL();
+  let text = doc.getText();
+
+  const resource = fParser.parse(fromVsCodeUri(doc.uri), text);
+  const textReplaceArr = await generateMarkdownLinks(resource, fWorkspace);
+  function escapeRegExp(string) {
+    return string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  }
+
+  textReplaceArr.forEach(({ from, to }) => {
+    text = text.replace(new RegExp(escapeRegExp(from), 'g'), to);
+  });
+
+  const basePath = doc.uri.path.split('/').slice(0, -1).join('/');
+
+  const fileUri = vscode.Uri.file(
+    `${
+      basePath ? basePath + '/' : ''
+    }${resource.uri.getName()}.standalone${resource.uri.getExtension()}`
+  );
+  const encoder = new TextEncoder();
+  await vscode.workspace.fs.writeFile(fileUri, encoder.encode(text));
+  await window.showTextDocument(fileUri);
+  await commands.executeCommand('foam-vscode.update-wikilink-definitions');
+}
diff --git a/packages/foam-vscode/src/features/commands/index.ts b/packages/foam-vscode/src/features/commands/index.ts
index 7e24a09b6..7ce638fa2 100644
--- a/packages/foam-vscode/src/features/commands/index.ts
+++ b/packages/foam-vscode/src/features/commands/index.ts
@@ -10,3 +10,4 @@ export { default as openResource } from './open-resource';
 export { default as updateGraphCommand } from './update-graph';
 export { default as updateWikilinksCommand } from './update-wikilinks';
 export { default as createNote } from './create-note';
+export { default as generateStandaloneNote } from './generate-standalone-note';

From bcfde0e0591b529409a4ab98cf4234481908bb1b Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Fri, 21 Jun 2024 19:50:29 +0800
Subject: [PATCH 03/23] vscode cmd configure

---
 packages/foam-vscode/package.json | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/packages/foam-vscode/package.json b/packages/foam-vscode/package.json
index ae27dc969..0df1ce369 100644
--- a/packages/foam-vscode/package.json
+++ b/packages/foam-vscode/package.json
@@ -346,6 +346,10 @@
         "command": "foam-vscode.open-resource",
         "title": "Foam: Open Resource"
       },
+      {
+        "command": "foam-vscode.generate-standalone-note",
+        "title": "Foam: generate standalone copy without wikilinks"
+      },
       {
         "command": "foam-vscode.views.orphans.group-by:folder",
         "title": "Group By Folder",

From 76ed1ad84fadef8b481d9139abcb82d2fe58e439 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Fri, 21 Jun 2024 21:23:57 +0800
Subject: [PATCH 04/23] fix embeded wikilinks

---
 .../src/core/janitor/generate-mdlinks.ts          | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts b/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts
index 3cc6ed395..dff7268f4 100644
--- a/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts
+++ b/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts
@@ -90,6 +90,17 @@ export const generateMarkdownLinks = async (
     return [] as TextReplace[];
   }
 
+  const rawText2isEmbedMap = note.links
+    .filter(link => link.type === 'wikilink')
+    .reduce((acc, link) => {
+      const rawText = link.rawText.substring(
+        link.isEmbed ? 3 : 2,
+        link.rawText.length - 2
+      );
+      acc[rawText] = link.isEmbed;
+      return acc;
+    }, {});
+
   const newWikilinkDefinitions = createMarkdownReferences(
     workspace,
     note,
@@ -98,7 +109,9 @@ export const generateMarkdownLinks = async (
   const wikilinkRawTextParser = new WikilinkRawText();
   const toReplaceArray = newWikilinkDefinitions.map(definition => {
     return {
-      from: `[[${definition.label}]]`,
+      from: `${rawText2isEmbedMap[definition.label] ? '!' : ''}[[${
+        definition.label
+      }]]`,
       to: wikilinkRawTextParser.toMarkdownLink(definition, note),
     };
   });

From 07702c20d999fecaa237ea10629ba9626d69630b Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 23 Jun 2024 22:38:17 +0800
Subject: [PATCH 05/23] refactor convertLinksFormat function & add 4 user
 command interfaces

---
 packages/foam-vscode/package.json             |  16 +-
 ...s.test.ts => convert-links-format.test.ts} |  34 ++-
 .../src/core/janitor/convert-links-format.ts  | 105 +++++++++
 .../src/core/janitor/generate-mdlinks.ts      | 120 ----------
 .../foam-vscode/src/core/janitor/index.ts     |   2 +-
 .../commands/convert-links-format-in-note.ts  | 207 ++++++++++++++++++
 .../commands/generate-standalone-note.ts      |  73 ------
 .../src/features/commands/index.ts            |   2 +-
 8 files changed, 353 insertions(+), 206 deletions(-)
 rename packages/foam-vscode/src/core/janitor/{generate-mdlinks.test.ts => convert-links-format.test.ts} (60%)
 create mode 100644 packages/foam-vscode/src/core/janitor/convert-links-format.ts
 delete mode 100644 packages/foam-vscode/src/core/janitor/generate-mdlinks.ts
 create mode 100644 packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
 delete mode 100644 packages/foam-vscode/src/features/commands/generate-standalone-note.ts

diff --git a/packages/foam-vscode/package.json b/packages/foam-vscode/package.json
index 0df1ce369..4d7a6a9df 100644
--- a/packages/foam-vscode/package.json
+++ b/packages/foam-vscode/package.json
@@ -347,8 +347,20 @@
         "title": "Foam: Open Resource"
       },
       {
-        "command": "foam-vscode.generate-standalone-note",
-        "title": "Foam: generate standalone copy without wikilinks"
+        "command": "foam-vscode.convert-wikilink-to-markdownlink-inplace",
+        "title": "Foam: convert wikilinks to markdown link format in place"
+      },
+      {
+        "command": "foam-vscode.convert-markdownlink-to-wikilink-inplace",
+        "title": "Foam: convert markdown links to wikilinks format in place"
+      },
+      {
+        "command": "foam-vscode.convert-wikilink-to-markdownlink-incopy",
+        "title": "Foam: convert wikilinks to markdown link format in copy"
+      },
+      {
+        "command": "foam-vscode.convert-markdownlink-to-wikilink-incopy",
+        "title": "Foam: convert markdown links to wikilinks format in copy"
       },
       {
         "command": "foam-vscode.views.orphans.group-by:folder",
diff --git a/packages/foam-vscode/src/core/janitor/generate-mdlinks.test.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.test.ts
similarity index 60%
rename from packages/foam-vscode/src/core/janitor/generate-mdlinks.test.ts
rename to packages/foam-vscode/src/core/janitor/convert-links-format.test.ts
index ad8a5af1a..489b2b89e 100644
--- a/packages/foam-vscode/src/core/janitor/generate-mdlinks.test.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.test.ts
@@ -1,4 +1,4 @@
-import { generateMarkdownLinks } from './generate-mdlinks';
+import { convertLinkFormat } from '.';
 import { TEST_DATA_DIR } from '../../test/test-utils';
 import { MarkdownResourceProvider } from '../services/markdown-provider';
 import { Resource } from '../model/note';
@@ -39,17 +39,33 @@ describe('generateStdMdLink', () => {
 
   it('can generate markdown links correctly', async () => {
     const note = findBySlug('file-with-different-link-formats');
-    const actual = await generateMarkdownLinks(note, _workspace);
+    const actual = note.links
+      .filter(link => link.type === 'wikilink')
+      .map(link => convertLinkFormat(link, 'link', _workspace, note));
     const expected: string[] = [
-      '[first-document](first-document.md "First Document")',
-      '[second-document](second-document.md "Second Document")',
-      '[#one section](<#one section> "File with different link formats")',
-      '[another name](<#one section> "File with different link formats")',
-      '[an alias](first-document.md "First Document")',
+      '[first-document](first-document.md)',
+      '[second-document](second-document.md)',
+      '[[non-exist-file]]',
+      '[#one section](<#one section>)',
+      '[another name](<#one section>)',
+      '[an alias](first-document.md)',
+      '[first-document](first-document.md)',
     ];
     expect(actual.length).toEqual(expected.length);
-    const _ = actual.map((textReplace, index) => {
-      expect(textReplace.to).toEqual(expected[index]);
+    const _ = actual.map((LinkReplace, index) => {
+      expect(LinkReplace.newText).toEqual(expected[index]);
+    });
+  });
+
+  it('can generate wikilinks correctly', async () => {
+    const note = findBySlug('file-with-different-link-formats');
+    const actual = note.links
+      .filter(link => link.type === 'link')
+      .map(link => convertLinkFormat(link, 'wikilink', _workspace, note));
+    const expected: string[] = ['[[first-document|file]]'];
+    expect(actual.length).toEqual(expected.length);
+    const _ = actual.map((LinkReplace, index) => {
+      expect(LinkReplace.newText).toEqual(expected[index]);
     });
   });
 });
diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
new file mode 100644
index 000000000..4f0389c45
--- /dev/null
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -0,0 +1,105 @@
+import { Resource, ResourceLink } from '../model/note';
+import { URI } from '../model/uri';
+import { Range } from '../model/range';
+import { FoamWorkspace } from '../model/workspace';
+import { isNone } from '../utils';
+import { MarkdownLink } from '../services/markdown-link';
+
+export interface LinkReplace {
+  newText: string;
+  range: Range /* old range */;
+}
+
+export function convertLinkFormat(
+  link: ResourceLink,
+  targetFormat: string,
+  workspace: FoamWorkspace,
+  note: Resource | URI
+): LinkReplace {
+  const resource = note instanceof URI ? workspace.find(note) : note;
+  const targetUri = workspace.resolveLink(resource, link);
+  /* If it's already the target format or a placeholder, no transformation happens */
+  if (link.type === targetFormat || targetUri.scheme === 'placeholder') {
+    return {
+      newText: link.rawText,
+      range: link.range,
+    };
+  }
+
+  let { target, section, alias } = MarkdownLink.analyzeLink(link);
+  let sectionDivider = section ? '#' : '';
+  let aliasDivider = alias ? '|' : '';
+  let embed = link.isEmbed ? '!' : '';
+
+  if (isNone(targetUri)) {
+    throw new Error(
+      `Unexpected state: link to: "${link.rawText}" is not resolvable`
+    );
+  }
+
+  const targetRes = workspace.find(targetUri);
+  let relativeUri = targetRes.uri.relativeTo(resource.uri.getDirectory());
+
+  if (targetFormat === 'wikilink') {
+    /* remove extension if possible, then get the basename to prevent from filename conflict */
+    if (relativeUri.path.endsWith(workspace.defaultExtension)) {
+      relativeUri = relativeUri.changeExtension('*', '');
+    }
+    target = relativeUri.getBasename();
+
+    return {
+      newText: `${embed}[[${target}${sectionDivider}${section}${aliasDivider}${alias}]]`,
+      range: link.range,
+    };
+  }
+  if (targetFormat === 'link') {
+    /* if alias is empty, construct one as target#section */
+    if (alias === '') {
+      /* in page anchor have no filename */
+      if (relativeUri.getBasename() === resource.uri.getBasename()) {
+        target = '';
+      }
+      alias = `${target}${sectionDivider}${section}`;
+    }
+
+    /* construct url */
+    let url = relativeUri.path;
+    /* in page anchor have no filename */
+    if (relativeUri.getBasename() === resource.uri.getBasename()) {
+      url = '';
+    }
+    if (sectionDivider === '#') {
+      url = `${url}${sectionDivider}${section}`;
+    }
+    if (url.indexOf(' ') > 0) {
+      url = `<${url}>`;
+    }
+
+    /* if it's originally an embeded note, the markdown link shouldn't be embeded */
+    if (embed && targetRes.type === 'note') {
+      embed = '';
+    }
+    return {
+      newText: `${embed}[${alias}](${url})`,
+      range: link.range,
+    };
+  }
+  throw new Error(
+    `Unexpected state: targetFormat: ${targetFormat} is not supported`
+  );
+}
+
+// export const generateMarkdownLinks = async (
+//   note: Resource,
+//   workspace: FoamWorkspace
+// ): Promise<LinkReplace[]> => {
+//   if (!note) {
+//     return [] as LinkReplace[];
+//   }
+
+//   const toReplaceArray = note.links
+//     .filter(link => link.type === 'wikilink')
+//     .map(link => convertLinkFormat(link, 'link', workspace, note));
+
+//   return toReplaceArray;
+// };
diff --git a/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts b/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts
deleted file mode 100644
index dff7268f4..000000000
--- a/packages/foam-vscode/src/core/janitor/generate-mdlinks.ts
+++ /dev/null
@@ -1,120 +0,0 @@
-import { NoteLinkDefinition, Resource } from '../model/note';
-import { FoamWorkspace } from '../model/workspace';
-import { createMarkdownReferences } from '../services/markdown-provider';
-
-export interface TextReplace {
-  from: string;
-  to: string;
-}
-
-/**
- * parse wikilink's rawText
- * possible inpout:
- *  1. [[\<filename\>#\<section\>|\<label\>]]
- *  2. [[#\<section\>|\<label\>]]
- *  3. [[\<filename\>#\<section\>]]
- *  4. [[\<filename\>|\<label\>]]
- */
-class WikilinkRawText {
-  private lable_m: string = '';
-  private filename_m: string = '';
-  private section_m: string = '';
-
-  public readFromText(definition: NoteLinkDefinition): WikilinkRawText {
-    const struct_rawText_regex =
-      /(?:(?<filename>[^\]|#]+)?(?:#(?<section>[^\]|]+))?)?(?:\|(?<label>[^\]]+))?/;
-    const match_result = definition.label.match(struct_rawText_regex);
-    if (match_result) {
-      this.filename_m = match_result[1];
-      this.section_m = match_result[2];
-      this.lable_m = match_result[3];
-    }
-    return this;
-  }
-
-  public getLable(): string {
-    if (this.lable_m) {
-      return this.lable_m;
-    }
-    // return `${this.getFilename()}${this.section_m ? '#' : ''}${this.getSection()}`;
-    return '';
-  }
-  public getFilename(): string {
-    if (this.filename_m) {
-      return this.filename_m;
-    }
-    return '';
-  }
-  public getSection(): string {
-    if (this.section_m) {
-      return this.section_m;
-    }
-    return '';
-  }
-  public toMarkdownLink(
-    definition: NoteLinkDefinition,
-    toNote: Resource
-  ): string {
-    const struct_rawText_regex =
-      /(?:(?<filename>[^\]|#]+)?(?:#(?<section>[^\]|]+))?)?(?:\|(?<label>[^\]]+))?/;
-    const match_result = definition.label.match(struct_rawText_regex);
-    this.filename_m = match_result[1];
-    this.section_m = match_result[2];
-    this.lable_m = match_result[3];
-
-    let url = `${
-      definition.url !== toNote.uri.getBasename() ? definition.url : ''
-    }${this.section_m ? `#${this.getSection()}` : ''}`;
-    if (url.indexOf(' ') > 0) {
-      url = `<${url}>`;
-    }
-    url = `(${url}${definition.title ? ` "${definition.title}"` : ''})`;
-
-    let label = this.lable_m;
-    let filename =
-      this.getFilename() !== toNote.uri.getName() ? this.getFilename() : '';
-    let section = this.getSection();
-    if (!label) {
-      label = `${filename}${this.section_m ? `#${section}` : ''}`;
-    }
-
-    return `[${label}]${url}`;
-  }
-}
-
-export const generateMarkdownLinks = async (
-  note: Resource,
-  workspace: FoamWorkspace
-): Promise<TextReplace[]> => {
-  if (!note) {
-    return [] as TextReplace[];
-  }
-
-  const rawText2isEmbedMap = note.links
-    .filter(link => link.type === 'wikilink')
-    .reduce((acc, link) => {
-      const rawText = link.rawText.substring(
-        link.isEmbed ? 3 : 2,
-        link.rawText.length - 2
-      );
-      acc[rawText] = link.isEmbed;
-      return acc;
-    }, {});
-
-  const newWikilinkDefinitions = createMarkdownReferences(
-    workspace,
-    note,
-    true
-  );
-  const wikilinkRawTextParser = new WikilinkRawText();
-  const toReplaceArray = newWikilinkDefinitions.map(definition => {
-    return {
-      from: `${rawText2isEmbedMap[definition.label] ? '!' : ''}[[${
-        definition.label
-      }]]`,
-      to: wikilinkRawTextParser.toMarkdownLink(definition, note),
-    };
-  });
-
-  return toReplaceArray;
-};
diff --git a/packages/foam-vscode/src/core/janitor/index.ts b/packages/foam-vscode/src/core/janitor/index.ts
index bcebfa984..9e836e97a 100644
--- a/packages/foam-vscode/src/core/janitor/index.ts
+++ b/packages/foam-vscode/src/core/janitor/index.ts
@@ -1,3 +1,3 @@
 export { generateLinkReferences } from './generate-link-references';
 export { generateHeading } from './generate-headings';
-export { generateMarkdownLinks } from './generate-mdlinks';
+export { convertLinkFormat } from './convert-links-format';
diff --git a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
new file mode 100644
index 000000000..512dfcde0
--- /dev/null
+++ b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
@@ -0,0 +1,207 @@
+import { commands, ExtensionContext, window } from 'vscode';
+import { isMdEditor } from '../../utils';
+import { Foam } from '../../core/model/foam';
+import { FoamWorkspace } from '../../core/model/workspace';
+import { fromVsCodeUri, toVsCodeRange } from '../../utils/vsc-utils';
+import { ResourceParser } from '../../core/model/note';
+import { IMatcher } from '../../core/services/datastore';
+import { convertLinkFormat } from '../../core/janitor';
+const vscode = require('vscode'); /* cannot import workspace from above statement and not sure what happened */
+
+enum ConvertOption {
+  Wikilink2MDlink,
+  MDlink2Wikilink,
+}
+
+interface IConfig {
+  from: string;
+  to: string;
+}
+
+const Config: { [key in ConvertOption]: IConfig } = {
+  [ConvertOption.Wikilink2MDlink]: {
+    from: 'wikilink',
+    to: 'link',
+  },
+  [ConvertOption.MDlink2Wikilink]: {
+    from: 'link',
+    to: 'wikilink',
+  },
+};
+
+export default async function activate(
+  context: ExtensionContext,
+  foamPromise: Promise<Foam>
+) {
+  const foam = await foamPromise;
+
+  /* 
+  commands:
+  foam-vscode.convert-wikilink-to-markdownlink-inplace
+  foam-vscode.convert-markdownlink-to-wikilink-inplace
+  foam-vscode.convert-wikilink-to-markdownlink-in-copy
+  foam-vscode.convert-markdownlink-to-wikilink-in-copy
+   */
+  context.subscriptions.push(
+    commands.registerCommand(
+      'foam-vscode.convert-wikilink-to-markdownlink-inplace',
+      () => {
+        return convertLinkInPlace(
+          foam.workspace,
+          foam.services.parser,
+          foam.services.matcher,
+          Config[ConvertOption.Wikilink2MDlink]
+        );
+      }
+    ),
+    commands.registerCommand(
+      'foam-vscode.convert-markdownlink-to-wikilink-inplace',
+      () => {
+        return convertLinkInPlace(
+          foam.workspace,
+          foam.services.parser,
+          foam.services.matcher,
+          Config[ConvertOption.MDlink2Wikilink]
+        );
+      }
+    ),
+    commands.registerCommand(
+      'foam-vscode.convert-wikilink-to-markdownlink-incopy',
+      () => {
+        return convertLinkInCopy(
+          foam.workspace,
+          foam.services.parser,
+          foam.services.matcher,
+          Config[ConvertOption.Wikilink2MDlink]
+        );
+      }
+    ),
+    commands.registerCommand(
+      'foam-vscode.convert-markdownlink-to-wikilink-incopy',
+      () => {
+        return convertLinkInCopy(
+          foam.workspace,
+          foam.services.parser,
+          foam.services.matcher,
+          Config[ConvertOption.MDlink2Wikilink]
+        );
+      }
+    )
+  );
+}
+
+async function convertLinkInPlace(
+  fWorkspace: FoamWorkspace,
+  fParser: ResourceParser,
+  fMatcher: IMatcher,
+  convertOption: IConfig
+) {
+  const editor = window.activeTextEditor;
+  const doc = editor.document;
+
+  if (!isMdEditor(editor) || !fMatcher.isMatch(fromVsCodeUri(doc.uri))) {
+    return;
+  }
+  // const eol = getEditorEOL();
+  let text = doc.getText();
+
+  const resource = fParser.parse(fromVsCodeUri(doc.uri), text);
+
+  const textReplaceArr = resource.links
+    .filter(link => link.type === convertOption.from)
+    .map(link =>
+      convertLinkFormat(link, convertOption.to, fWorkspace, resource)
+    )
+    /* transform .range property into vscode range */
+    .map(linkReplace => ({
+      ...linkReplace,
+      range: toVsCodeRange(linkReplace.range),
+    }));
+
+  /* reorder the array such that the later range comes first */
+  textReplaceArr.sort((a, b) => b.range.start.compareTo(a.range.start));
+
+  await editor.edit(editorBuilder => {
+    textReplaceArr.forEach(edit => {
+      editorBuilder.replace(edit.range, edit.newText);
+    });
+  });
+}
+
+async function convertLinkInCopy(
+  fWorkspace: FoamWorkspace,
+  fParser: ResourceParser,
+  fMatcher: IMatcher,
+  convertOption: IConfig
+) {
+  const editor = window.activeTextEditor;
+  const doc = editor.document;
+
+  if (!isMdEditor(editor) || !fMatcher.isMatch(fromVsCodeUri(doc.uri))) {
+    return;
+  }
+  // const eol = getEditorEOL();
+  let text = doc.getText();
+
+  const resource = fParser.parse(fromVsCodeUri(doc.uri), text);
+  const basePath = doc.uri.path.split('/').slice(0, -1).join('/');
+
+  const fileUri = vscode.Uri.file(
+    `${
+      basePath ? basePath + '/' : ''
+    }${resource.uri.getName()}.copy${resource.uri.getExtension()}`
+  );
+  const encoder = new TextEncoder();
+  await vscode.workspace.fs.writeFile(fileUri, encoder.encode(text));
+  await window.showTextDocument(fileUri);
+
+  await convertLinkInPlace(fWorkspace, fParser, fMatcher, convertOption);
+}
+
+// /**
+//  * based on generate-link-references,
+//  * copy the current note,
+//  * replace wikilinks in it,
+//  * save it at the same directory,
+//  * call update-wikilinks to remove link references if neccessary
+//  */
+// async function generateStandaloneNote(
+//   fWorkspace: FoamWorkspace,
+//   fParser: ResourceParser,
+//   fMatcher: IMatcher
+// ) {
+//   const editor = window.activeTextEditor;
+//   const doc = editor.document;
+
+//   if (!isMdEditor(editor) || !fMatcher.isMatch(fromVsCodeUri(doc.uri))) {
+//     return;
+//   }
+
+//   // const setting = getWikilinkDefinitionSetting();
+//   const eol = getEditorEOL();
+//   let text = doc.getText();
+
+//   const resource = fParser.parse(fromVsCodeUri(doc.uri), text);
+//   const textReplaceArr = resource.links
+//     .filter(link => link.type === 'wikilink')
+//     .map(link => convertLinkFormat(link, 'link', fWorkspace, resource));
+//   // function escapeRegExp(string) {
+//   //   return string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+//   // }
+
+//   // textReplaceArr.forEach(({ from, to }) => {
+//   //   text = text.replace(new RegExp(escapeRegExp(from), 'g'), to);
+//   // });
+
+//   // const basePath = doc.uri.path.split('/').slice(0, -1).join('/');
+
+//   // const fileUri = vscode.Uri.file(
+//   //   `${
+//   //     basePath ? basePath + '/' : ''
+//   //   }${resource.uri.getName()}.standalone${resource.uri.getExtension()}`
+//   // );
+//   // const encoder = new TextEncoder();
+//   // await vscode.workspace.fs.writeFile(fileUri, encoder.encode(text));
+//   // await window.showTextDocument(fileUri);
+//   // await commands.executeCommand('foam-vscode.update-wikilink-definitions');
+// }
diff --git a/packages/foam-vscode/src/features/commands/generate-standalone-note.ts b/packages/foam-vscode/src/features/commands/generate-standalone-note.ts
deleted file mode 100644
index 4084c6c1d..000000000
--- a/packages/foam-vscode/src/features/commands/generate-standalone-note.ts
+++ /dev/null
@@ -1,73 +0,0 @@
-import { commands, ExtensionContext, window } from 'vscode';
-import { isMdEditor } from '../../utils';
-import { Foam } from '../../core/model/foam';
-import { FoamWorkspace } from '../../core/model/workspace';
-import { fromVsCodeUri } from '../../utils/vsc-utils';
-import { getEditorEOL } from '../../services/editor';
-import { ResourceParser } from '../../core/model/note';
-import { IMatcher } from '../../core/services/datastore';
-import { generateMarkdownLinks } from '../../core/janitor';
-const vscode = require('vscode'); /* cannot import workspace from above statement and not sure what happened */
-
-export default async function activate(
-  context: ExtensionContext,
-  foamPromise: Promise<Foam>
-) {
-  const foam = await foamPromise;
-
-  context.subscriptions.push(
-    commands.registerCommand('foam-vscode.generate-standalone-note', () => {
-      return generateStandaloneNote(
-        foam.workspace,
-        foam.services.parser,
-        foam.services.matcher
-      );
-    })
-  );
-}
-
-/**
- * based on generate-link-references,
- * copy the current note,
- * replace wikilinks in it,
- * save it at the same directory,
- * call update-wikilinks to remove link references if neccessary
- */
-async function generateStandaloneNote(
-  fWorkspace: FoamWorkspace,
-  fParser: ResourceParser,
-  fMatcher: IMatcher
-) {
-  const editor = window.activeTextEditor;
-  const doc = editor.document;
-
-  if (!isMdEditor(editor) || !fMatcher.isMatch(fromVsCodeUri(doc.uri))) {
-    return;
-  }
-
-  // const setting = getWikilinkDefinitionSetting();
-  const eol = getEditorEOL();
-  let text = doc.getText();
-
-  const resource = fParser.parse(fromVsCodeUri(doc.uri), text);
-  const textReplaceArr = await generateMarkdownLinks(resource, fWorkspace);
-  function escapeRegExp(string) {
-    return string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-  }
-
-  textReplaceArr.forEach(({ from, to }) => {
-    text = text.replace(new RegExp(escapeRegExp(from), 'g'), to);
-  });
-
-  const basePath = doc.uri.path.split('/').slice(0, -1).join('/');
-
-  const fileUri = vscode.Uri.file(
-    `${
-      basePath ? basePath + '/' : ''
-    }${resource.uri.getName()}.standalone${resource.uri.getExtension()}`
-  );
-  const encoder = new TextEncoder();
-  await vscode.workspace.fs.writeFile(fileUri, encoder.encode(text));
-  await window.showTextDocument(fileUri);
-  await commands.executeCommand('foam-vscode.update-wikilink-definitions');
-}
diff --git a/packages/foam-vscode/src/features/commands/index.ts b/packages/foam-vscode/src/features/commands/index.ts
index 7ce638fa2..5ed245f07 100644
--- a/packages/foam-vscode/src/features/commands/index.ts
+++ b/packages/foam-vscode/src/features/commands/index.ts
@@ -10,4 +10,4 @@ export { default as openResource } from './open-resource';
 export { default as updateGraphCommand } from './update-graph';
 export { default as updateWikilinksCommand } from './update-wikilinks';
 export { default as createNote } from './create-note';
-export { default as generateStandaloneNote } from './generate-standalone-note';
+export { default as generateStandaloneNote } from './convert-links-format-in-note';

From 62f458e260b2b522dad4f697ea5c5af327e0690d Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 23 Jun 2024 22:41:42 +0800
Subject: [PATCH 06/23] cleanup

---
 .../src/core/janitor/convert-links-format.ts  | 15 ------
 .../commands/convert-links-format-in-note.ts  | 48 -------------------
 2 files changed, 63 deletions(-)

diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index 4f0389c45..12144e7b7 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -88,18 +88,3 @@ export function convertLinkFormat(
     `Unexpected state: targetFormat: ${targetFormat} is not supported`
   );
 }
-
-// export const generateMarkdownLinks = async (
-//   note: Resource,
-//   workspace: FoamWorkspace
-// ): Promise<LinkReplace[]> => {
-//   if (!note) {
-//     return [] as LinkReplace[];
-//   }
-
-//   const toReplaceArray = note.links
-//     .filter(link => link.type === 'wikilink')
-//     .map(link => convertLinkFormat(link, 'link', workspace, note));
-
-//   return toReplaceArray;
-// };
diff --git a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
index 512dfcde0..7000bc7ce 100644
--- a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
+++ b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
@@ -157,51 +157,3 @@ async function convertLinkInCopy(
 
   await convertLinkInPlace(fWorkspace, fParser, fMatcher, convertOption);
 }
-
-// /**
-//  * based on generate-link-references,
-//  * copy the current note,
-//  * replace wikilinks in it,
-//  * save it at the same directory,
-//  * call update-wikilinks to remove link references if neccessary
-//  */
-// async function generateStandaloneNote(
-//   fWorkspace: FoamWorkspace,
-//   fParser: ResourceParser,
-//   fMatcher: IMatcher
-// ) {
-//   const editor = window.activeTextEditor;
-//   const doc = editor.document;
-
-//   if (!isMdEditor(editor) || !fMatcher.isMatch(fromVsCodeUri(doc.uri))) {
-//     return;
-//   }
-
-//   // const setting = getWikilinkDefinitionSetting();
-//   const eol = getEditorEOL();
-//   let text = doc.getText();
-
-//   const resource = fParser.parse(fromVsCodeUri(doc.uri), text);
-//   const textReplaceArr = resource.links
-//     .filter(link => link.type === 'wikilink')
-//     .map(link => convertLinkFormat(link, 'link', fWorkspace, resource));
-//   // function escapeRegExp(string) {
-//   //   return string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-//   // }
-
-//   // textReplaceArr.forEach(({ from, to }) => {
-//   //   text = text.replace(new RegExp(escapeRegExp(from), 'g'), to);
-//   // });
-
-//   // const basePath = doc.uri.path.split('/').slice(0, -1).join('/');
-
-//   // const fileUri = vscode.Uri.file(
-//   //   `${
-//   //     basePath ? basePath + '/' : ''
-//   //   }${resource.uri.getName()}.standalone${resource.uri.getExtension()}`
-//   // );
-//   // const encoder = new TextEncoder();
-//   // await vscode.workspace.fs.writeFile(fileUri, encoder.encode(text));
-//   // await window.showTextDocument(fileUri);
-//   // await commands.executeCommand('foam-vscode.update-wikilink-definitions');
-// }

From 0aefd720e88b6a9d0d77b67489ade2afd5897587 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 23 Jun 2024 23:08:32 +0800
Subject: [PATCH 07/23] add comments

---
 .../src/core/janitor/convert-links-format.ts  | 13 ++++++++++++
 .../commands/convert-links-format-in-note.ts  | 20 +++++++++++++++++++
 2 files changed, 33 insertions(+)

diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index 12144e7b7..235460f2c 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -10,6 +10,18 @@ export interface LinkReplace {
   range: Range /* old range */;
 }
 
+/**
+ * convert a link based on its workspace and the note containing it.
+ * According to targetFormat parameter to decide output format. If link.type === targetFormat, then it simply copy
+ * the rawText into LinkReplace. Therefore, it's recommanded to filter before conversion.
+ * If targetFormat isn't supported, or the target resource pointed by link cannot be found, the function will throw
+ * exception.
+ * @param link
+ * @param targetFormat
+ * @param workspace
+ * @param note
+ * @returns LinkReplace { newText: string; range: Range; }
+ */
 export function convertLinkFormat(
   link: ResourceLink,
   targetFormat: string,
@@ -52,6 +64,7 @@ export function convertLinkFormat(
       range: link.range,
     };
   }
+
   if (targetFormat === 'link') {
     /* if alias is empty, construct one as target#section */
     if (alias === '') {
diff --git a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
index 7000bc7ce..820388f57 100644
--- a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
+++ b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
@@ -90,6 +90,15 @@ export default async function activate(
   );
 }
 
+/**
+ * convert links based on its workspace and the note containing it.
+ * Changes happen in-place
+ * @param fWorkspace
+ * @param fParser
+ * @param fMatcher
+ * @param convertOption
+ * @returns void
+ */
 async function convertLinkInPlace(
   fWorkspace: FoamWorkspace,
   fParser: ResourceParser,
@@ -128,6 +137,17 @@ async function convertLinkInPlace(
   });
 }
 
+/**
+ * convert links based on its workspace and the note containing it.
+ * Changes happen in a copy
+ * 1. prepare a copy file, and makt it the activeTextEditor
+ * 2. call to convertLinkInPlace
+ * @param fWorkspace
+ * @param fParser
+ * @param fMatcher
+ * @param convertOption
+ * @returns void
+ */
 async function convertLinkInCopy(
   fWorkspace: FoamWorkspace,
   fParser: ResourceParser,

From 2e350d7a7ff39449afb8d84dc60085b3342f6d41 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Mon, 24 Jun 2024 21:02:20 +0800
Subject: [PATCH 08/23] change user interface

---
 packages/foam-vscode/package.json             |  16 +--
 .../src/core/janitor/convert-links-format.ts  |   4 +-
 .../commands/convert-links-format-in-note.ts  | 108 ++++++++++--------
 3 files changed, 69 insertions(+), 59 deletions(-)

diff --git a/packages/foam-vscode/package.json b/packages/foam-vscode/package.json
index 4d7a6a9df..b2e5a452c 100644
--- a/packages/foam-vscode/package.json
+++ b/packages/foam-vscode/package.json
@@ -347,20 +347,12 @@
         "title": "Foam: Open Resource"
       },
       {
-        "command": "foam-vscode.convert-wikilink-to-markdownlink-inplace",
-        "title": "Foam: convert wikilinks to markdown link format in place"
+        "command": "foam-vscode.convert-link-style-inplace",
+        "title": "Foam: convert link style in place"
       },
       {
-        "command": "foam-vscode.convert-markdownlink-to-wikilink-inplace",
-        "title": "Foam: convert markdown links to wikilinks format in place"
-      },
-      {
-        "command": "foam-vscode.convert-wikilink-to-markdownlink-incopy",
-        "title": "Foam: convert wikilinks to markdown link format in copy"
-      },
-      {
-        "command": "foam-vscode.convert-markdownlink-to-wikilink-incopy",
-        "title": "Foam: convert markdown links to wikilinks format in copy"
+        "command": "foam-vscode.convert-link-style-incopy",
+        "title": "Foam: convert link format in copy"
       },
       {
         "command": "foam-vscode.views.orphans.group-by:folder",
diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index 235460f2c..841ce7bd6 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -17,14 +17,14 @@ export interface LinkReplace {
  * If targetFormat isn't supported, or the target resource pointed by link cannot be found, the function will throw
  * exception.
  * @param link
- * @param targetFormat
+ * @param targetFormat 'wikilink' | 'link'
  * @param workspace
  * @param note
  * @returns LinkReplace { newText: string; range: Range; }
  */
 export function convertLinkFormat(
   link: ResourceLink,
-  targetFormat: string,
+  targetFormat: 'wikilink' | 'link',
   workspace: FoamWorkspace,
   note: Resource | URI
 ): LinkReplace {
diff --git a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
index 820388f57..5b98833db 100644
--- a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
+++ b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
@@ -8,6 +8,8 @@ import { IMatcher } from '../../core/services/datastore';
 import { convertLinkFormat } from '../../core/janitor';
 const vscode = require('vscode'); /* cannot import workspace from above statement and not sure what happened */
 
+type LinkFormat = 'wikilink' | 'link';
+
 enum ConvertOption {
   Wikilink2MDlink,
   MDlink2Wikilink,
@@ -42,54 +44,65 @@ export default async function activate(
   foam-vscode.convert-wikilink-to-markdownlink-in-copy
   foam-vscode.convert-markdownlink-to-wikilink-in-copy
    */
+
+  /* 
+  commands: 
+  foam-vscode.convert-link-style-inplace
+  foam-vscode.convert-link-style-incopy
+  */
   context.subscriptions.push(
-    commands.registerCommand(
-      'foam-vscode.convert-wikilink-to-markdownlink-inplace',
-      () => {
-        return convertLinkInPlace(
-          foam.workspace,
-          foam.services.parser,
-          foam.services.matcher,
-          Config[ConvertOption.Wikilink2MDlink]
-        );
-      }
-    ),
-    commands.registerCommand(
-      'foam-vscode.convert-markdownlink-to-wikilink-inplace',
-      () => {
-        return convertLinkInPlace(
-          foam.workspace,
-          foam.services.parser,
-          foam.services.matcher,
-          Config[ConvertOption.MDlink2Wikilink]
-        );
-      }
-    ),
-    commands.registerCommand(
-      'foam-vscode.convert-wikilink-to-markdownlink-incopy',
-      () => {
-        return convertLinkInCopy(
-          foam.workspace,
-          foam.services.parser,
-          foam.services.matcher,
-          Config[ConvertOption.Wikilink2MDlink]
-        );
-      }
-    ),
-    commands.registerCommand(
-      'foam-vscode.convert-markdownlink-to-wikilink-incopy',
-      () => {
-        return convertLinkInCopy(
-          foam.workspace,
-          foam.services.parser,
-          foam.services.matcher,
-          Config[ConvertOption.MDlink2Wikilink]
-        );
-      }
-    )
+    commands.registerCommand('foam-vscode.convert-link-style-inplace', () => {
+      return convertLinkAdapter(
+        foam.workspace,
+        foam.services.parser,
+        foam.services.matcher,
+        true
+      );
+    }),
+    commands.registerCommand('foam-vscode.convert-link-style-incopy', () => {
+      return convertLinkAdapter(
+        foam.workspace,
+        foam.services.parser,
+        foam.services.matcher,
+        false
+      );
+    })
   );
 }
 
+async function convertLinkAdapter(
+  fWorkspace: FoamWorkspace,
+  fParser: ResourceParser,
+  fMatcher: IMatcher,
+  isInPlace: boolean
+) {
+  const convertOption = await pickConvertStrategy();
+  if (!convertOption) {
+    window.showInformationMessage('Convert canceled');
+    return;
+  }
+
+  if (isInPlace) {
+    await convertLinkInPlace(fWorkspace, fParser, fMatcher, convertOption);
+  } else {
+    await convertLinkInCopy(fWorkspace, fParser, fMatcher, convertOption);
+  }
+}
+
+async function pickConvertStrategy(): Promise<IConfig | undefined> {
+  const options = {
+    'to wikilink': ConvertOption.MDlink2Wikilink,
+    'to markdown link': ConvertOption.Wikilink2MDlink,
+  };
+  return window.showQuickPick(Object.keys(options)).then(name => {
+    if (name) {
+      return Config[options[name]];
+    } else {
+      return undefined;
+    }
+  });
+}
+
 /**
  * convert links based on its workspace and the note containing it.
  * Changes happen in-place
@@ -119,7 +132,12 @@ async function convertLinkInPlace(
   const textReplaceArr = resource.links
     .filter(link => link.type === convertOption.from)
     .map(link =>
-      convertLinkFormat(link, convertOption.to, fWorkspace, resource)
+      convertLinkFormat(
+        link,
+        convertOption.to as LinkFormat,
+        fWorkspace,
+        resource
+      )
     )
     /* transform .range property into vscode range */
     .map(linkReplace => ({

From 08451f16242167aee86a151353034f7e1bd8049b Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Mon, 24 Jun 2024 21:26:40 +0800
Subject: [PATCH 09/23] del outdated comments

---
 .../src/features/commands/convert-links-format-in-note.ts | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
index 5b98833db..e2c652ce0 100644
--- a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
+++ b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
@@ -37,14 +37,6 @@ export default async function activate(
 ) {
   const foam = await foamPromise;
 
-  /* 
-  commands:
-  foam-vscode.convert-wikilink-to-markdownlink-inplace
-  foam-vscode.convert-markdownlink-to-wikilink-inplace
-  foam-vscode.convert-wikilink-to-markdownlink-in-copy
-  foam-vscode.convert-markdownlink-to-wikilink-in-copy
-   */
-
   /* 
   commands: 
   foam-vscode.convert-link-style-inplace

From 18dbbb5f937c26bff8a9d33f12e9c9d9e2da2b91 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Fri, 28 Jun 2024 22:09:26 +0800
Subject: [PATCH 10/23] fix typo

---
 packages/foam-vscode/src/core/janitor/convert-links-format.ts | 4 ++--
 .../__scaffold__/file-with-different-link-formats.md          | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index 841ce7bd6..5e4f35629 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -13,7 +13,7 @@ export interface LinkReplace {
 /**
  * convert a link based on its workspace and the note containing it.
  * According to targetFormat parameter to decide output format. If link.type === targetFormat, then it simply copy
- * the rawText into LinkReplace. Therefore, it's recommanded to filter before conversion.
+ * the rawText into LinkReplace. Therefore, it's recommended to filter before conversion.
  * If targetFormat isn't supported, or the target resource pointed by link cannot be found, the function will throw
  * exception.
  * @param link
@@ -88,7 +88,7 @@ export function convertLinkFormat(
       url = `<${url}>`;
     }
 
-    /* if it's originally an embeded note, the markdown link shouldn't be embeded */
+    /* if it's originally an embedded note, the markdown link shouldn't be embedded */
     if (embed && targetRes.type === 'note') {
       embed = '';
     }
diff --git a/packages/foam-vscode/test-data/__scaffold__/file-with-different-link-formats.md b/packages/foam-vscode/test-data/__scaffold__/file-with-different-link-formats.md
index 3ba8e9e74..7c282c0da 100644
--- a/packages/foam-vscode/test-data/__scaffold__/file-with-different-link-formats.md
+++ b/packages/foam-vscode/test-data/__scaffold__/file-with-different-link-formats.md
@@ -6,7 +6,7 @@ wikilink to file [[first-document]].
 
 markdown format link to local [file](first-document.md)
 
-embeded wikilink to file ![[second-document]].
+embedded wikilink to file ![[second-document]].
 
 wikilink to placeholder [[non-exist-file]]
 

From b38449148f5b211dc7dd15ff593cf955d857b41d Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Fri, 28 Jun 2024 23:32:37 +0800
Subject: [PATCH 11/23] modify createUpdateLinkEdit to accomplish convert

---
 .../src/core/janitor/convert-links-format.ts  | 32 ++++++++-----------
 .../src/core/services/markdown-link.ts        | 29 ++++++++++++-----
 2 files changed, 34 insertions(+), 27 deletions(-)

diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index 5e4f35629..89abb70b9 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -40,8 +40,6 @@ export function convertLinkFormat(
 
   let { target, section, alias } = MarkdownLink.analyzeLink(link);
   let sectionDivider = section ? '#' : '';
-  let aliasDivider = alias ? '|' : '';
-  let embed = link.isEmbed ? '!' : '';
 
   if (isNone(targetUri)) {
     throw new Error(
@@ -59,10 +57,10 @@ export function convertLinkFormat(
     }
     target = relativeUri.getBasename();
 
-    return {
-      newText: `${embed}[[${target}${sectionDivider}${section}${aliasDivider}${alias}]]`,
-      range: link.range,
-    };
+    return MarkdownLink.createUpdateLinkEdit(link, {
+      target: target,
+      type: 'wikilink',
+    });
   }
 
   if (targetFormat === 'link') {
@@ -81,21 +79,17 @@ export function convertLinkFormat(
     if (relativeUri.getBasename() === resource.uri.getBasename()) {
       url = '';
     }
-    if (sectionDivider === '#') {
-      url = `${url}${sectionDivider}${section}`;
-    }
-    if (url.indexOf(' ') > 0) {
-      url = `<${url}>`;
-    }
 
     /* if it's originally an embedded note, the markdown link shouldn't be embedded */
-    if (embed && targetRes.type === 'note') {
-      embed = '';
-    }
-    return {
-      newText: `${embed}[${alias}](${url})`,
-      range: link.range,
-    };
+    const isEmbed =
+      link.isEmbed && targetRes.type === 'note' ? false : undefined;
+
+    return MarkdownLink.createUpdateLinkEdit(link, {
+      alias: alias,
+      target: url,
+      isEmbed: isEmbed,
+      type: 'link',
+    });
   }
   throw new Error(
     `Unexpected state: targetFormat: ${targetFormat} is not supported`
diff --git a/packages/foam-vscode/src/core/services/markdown-link.ts b/packages/foam-vscode/src/core/services/markdown-link.ts
index e5c88bf3b..234e3e99f 100644
--- a/packages/foam-vscode/src/core/services/markdown-link.ts
+++ b/packages/foam-vscode/src/core/services/markdown-link.ts
@@ -38,7 +38,13 @@ export abstract class MarkdownLink {
 
   public static createUpdateLinkEdit(
     link: ResourceLink,
-    delta: { target?: string; section?: string; alias?: string }
+    delta: {
+      target?: string;
+      section?: string;
+      alias?: string;
+      type?: 'wikilink' | 'link';
+      isEmbed?: boolean;
+    }
   ) {
     const { target, section, alias } = MarkdownLink.analyzeLink(link);
     const newTarget = delta.target ?? target;
@@ -46,21 +52,28 @@ export abstract class MarkdownLink {
     const newAlias = delta.alias ?? alias ?? '';
     const sectionDivider = newSection ? '#' : '';
     const aliasDivider = newAlias ? '|' : '';
-    const embed = link.isEmbed ? '!' : '';
-    if (link.type === 'wikilink') {
+    const embed = (() => {
+      if (typeof delta.isEmbed === 'boolean') {
+        return delta.isEmbed ? '!' : '';
+      }
+      return link.isEmbed ? '!' : '';
+    })();
+    const type = delta.type ?? link.type;
+    const useAngles = newTarget.indexOf(' ') > 0 || newSection.indexOf(' ') > 0;
+    if (type === 'wikilink') {
       return {
         newText: `${embed}[[${newTarget}${sectionDivider}${newSection}${aliasDivider}${newAlias}]]`,
         range: link.range,
       };
     }
-    if (link.type === 'link') {
+    if (type === 'link') {
       return {
-        newText: `${embed}[${newAlias}](${newTarget}${sectionDivider}${newSection})`,
+        newText: `${embed}[${newAlias}](${
+          useAngles ? '<' : ''
+        }${newTarget}${sectionDivider}${newSection}${useAngles ? '>' : ''})`,
         range: link.range,
       };
     }
-    throw new Error(
-      `Unexpected state: link of type ${link.type} is not supported`
-    );
+    throw new Error(`Unexpected state: link of type ${type} is not supported`);
   }
 }

From 7adf32feaadf756899f1db0ecf6eb86cba72bdb7 Mon Sep 17 00:00:00 2001
From: Xinglan Liu <xinglanliu41@gmail.com>
Date: Sun, 30 Jun 2024 00:04:59 +0800
Subject: [PATCH 12/23] only images can be embedded

Co-authored-by: Riccardo <code@riccardoferretti.com>
---
 packages/foam-vscode/src/core/janitor/convert-links-format.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index 89abb70b9..eec42b231 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -82,7 +82,7 @@ export function convertLinkFormat(
 
     /* if it's originally an embedded note, the markdown link shouldn't be embedded */
     const isEmbed =
-      link.isEmbed && targetRes.type === 'note' ? false : undefined;
+      targetRes.type === 'image' ? link.isEmbed : false;
 
     return MarkdownLink.createUpdateLinkEdit(link, {
       alias: alias,

From 4483132723267d7fe4cee62c86a35b9f9208fa2c Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 30 Jun 2024 00:16:05 +0800
Subject: [PATCH 13/23] move useAngles to if-branch uses it

---
 packages/foam-vscode/src/core/services/markdown-link.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/foam-vscode/src/core/services/markdown-link.ts b/packages/foam-vscode/src/core/services/markdown-link.ts
index 234e3e99f..c4dec93de 100644
--- a/packages/foam-vscode/src/core/services/markdown-link.ts
+++ b/packages/foam-vscode/src/core/services/markdown-link.ts
@@ -59,7 +59,6 @@ export abstract class MarkdownLink {
       return link.isEmbed ? '!' : '';
     })();
     const type = delta.type ?? link.type;
-    const useAngles = newTarget.indexOf(' ') > 0 || newSection.indexOf(' ') > 0;
     if (type === 'wikilink') {
       return {
         newText: `${embed}[[${newTarget}${sectionDivider}${newSection}${aliasDivider}${newAlias}]]`,
@@ -67,6 +66,8 @@ export abstract class MarkdownLink {
       };
     }
     if (type === 'link') {
+      const useAngles =
+        newTarget.indexOf(' ') > 0 || newSection.indexOf(' ') > 0;
       return {
         newText: `${embed}[${newAlias}](${
           useAngles ? '<' : ''

From 8dd26c959cb8827bc8eb09d944522c35331b1716 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 30 Jun 2024 00:17:59 +0800
Subject: [PATCH 14/23] keey filename when using in page anchor

---
 .../src/core/janitor/convert-links-format.test.ts        | 4 ++--
 .../foam-vscode/src/core/janitor/convert-links-format.ts | 9 +--------
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.test.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.test.ts
index 489b2b89e..b0c8b3eae 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.test.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.test.ts
@@ -46,8 +46,8 @@ describe('generateStdMdLink', () => {
       '[first-document](first-document.md)',
       '[second-document](second-document.md)',
       '[[non-exist-file]]',
-      '[#one section](<#one section>)',
-      '[another name](<#one section>)',
+      '[#one section](<file-with-different-link-formats.md#one section>)',
+      '[another name](<file-with-different-link-formats.md#one section>)',
       '[an alias](first-document.md)',
       '[first-document](first-document.md)',
     ];
diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index eec42b231..76d49a86e 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -73,20 +73,13 @@ export function convertLinkFormat(
       alias = `${target}${sectionDivider}${section}`;
     }
 
-    /* construct url */
-    let url = relativeUri.path;
-    /* in page anchor have no filename */
-    if (relativeUri.getBasename() === resource.uri.getBasename()) {
-      url = '';
-    }
-
     /* if it's originally an embedded note, the markdown link shouldn't be embedded */
     const isEmbed =
       targetRes.type === 'image' ? link.isEmbed : false;
 
     return MarkdownLink.createUpdateLinkEdit(link, {
       alias: alias,
-      target: url,
+      target: relativeUri.path,
       isEmbed: isEmbed,
       type: 'link',
     });

From 7732e4bba16b2a3c0659725d1396d2c0886b8504 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 30 Jun 2024 00:20:55 +0800
Subject: [PATCH 15/23] remove redundant procedure

---
 packages/foam-vscode/src/core/janitor/convert-links-format.ts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index 76d49a86e..df9407573 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -55,10 +55,9 @@ export function convertLinkFormat(
     if (relativeUri.path.endsWith(workspace.defaultExtension)) {
       relativeUri = relativeUri.changeExtension('*', '');
     }
-    target = relativeUri.getBasename();
 
     return MarkdownLink.createUpdateLinkEdit(link, {
-      target: target,
+      target: relativeUri.getBasename(),
       type: 'wikilink',
     });
   }

From 8194b5c066a3fe16ae88843db22ee1d04153dead Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 30 Jun 2024 16:19:12 +0800
Subject: [PATCH 16/23] give a default value to alias in link format
 combination branch

---
 packages/foam-vscode/src/core/services/markdown-link.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/packages/foam-vscode/src/core/services/markdown-link.ts b/packages/foam-vscode/src/core/services/markdown-link.ts
index c4dec93de..ab273c703 100644
--- a/packages/foam-vscode/src/core/services/markdown-link.ts
+++ b/packages/foam-vscode/src/core/services/markdown-link.ts
@@ -66,10 +66,13 @@ export abstract class MarkdownLink {
       };
     }
     if (type === 'link') {
+      const defaultAlias = () => {
+        return `${newTarget}${sectionDivider}${newSection}`;
+      };
       const useAngles =
         newTarget.indexOf(' ') > 0 || newSection.indexOf(' ') > 0;
       return {
-        newText: `${embed}[${newAlias}](${
+        newText: `${embed}[${newAlias ? newAlias : defaultAlias()}](${
           useAngles ? '<' : ''
         }${newTarget}${sectionDivider}${newSection}${useAngles ? '>' : ''})`,
         range: link.range,

From 6765d52d700dac30f568867653c1964214b1bbd1 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 30 Jun 2024 16:20:50 +0800
Subject: [PATCH 17/23] add tests to createUpdateLinkEdit about changint links'
 type and isEmbed

---
 .../src/core/services/markdown-link.test.ts   | 136 ++++++++++++++++++
 1 file changed, 136 insertions(+)

diff --git a/packages/foam-vscode/src/core/services/markdown-link.test.ts b/packages/foam-vscode/src/core/services/markdown-link.test.ts
index 0377072f3..e2626ffb6 100644
--- a/packages/foam-vscode/src/core/services/markdown-link.test.ts
+++ b/packages/foam-vscode/src/core/services/markdown-link.test.ts
@@ -254,4 +254,140 @@ describe('MarkdownLink', () => {
       expect(edit.range).toEqual(link.range);
     });
   });
+
+  describe('convert wikilink to link', () => {
+    it('should generate default alias if no one', () => {
+      const wikilink = parser.parse(getRandomURI(), `[[wikilink]]`).links[0];
+      const wikilinkEdit = MarkdownLink.createUpdateLinkEdit(wikilink, {
+        type: 'link',
+      });
+      expect(wikilinkEdit.newText).toEqual(`[wikilink](wikilink)`);
+      expect(wikilinkEdit.range).toEqual(wikilink.range);
+
+      const wikilinkWithSection = parser.parse(
+        getRandomURI(),
+        `[[wikilink#section]]`
+      ).links[0];
+      const wikilinkWithSectionEdit = MarkdownLink.createUpdateLinkEdit(
+        wikilinkWithSection,
+        {
+          type: 'link',
+        }
+      );
+      expect(wikilinkWithSectionEdit.newText).toEqual(
+        `[wikilink#section](wikilink#section)`
+      );
+      expect(wikilinkWithSectionEdit.range).toEqual(wikilinkWithSection.range);
+    });
+
+    it('should use alias in the wikilik the if there has one', () => {
+      const wikilink = parser.parse(
+        getRandomURI(),
+        `[[wikilink#section|alias]]`
+      ).links[0];
+      const wikilinkEdit = MarkdownLink.createUpdateLinkEdit(wikilink, {
+        type: 'link',
+      });
+      expect(wikilinkEdit.newText).toEqual(`[alias](wikilink#section)`);
+      expect(wikilinkEdit.range).toEqual(wikilink.range);
+    });
+  });
+
+  describe('convert link to wikilink', () => {
+    it('should reorganize target, section, and alias in wikilink manner', () => {
+      const link = parser.parse(getRandomURI(), `[link](to/path.md)`).links[0];
+      const linkEdit = MarkdownLink.createUpdateLinkEdit(link, {
+        type: 'wikilink',
+      });
+      expect(linkEdit.newText).toEqual(`[[to/path.md|link]]`);
+      expect(linkEdit.range).toEqual(link.range);
+
+      const linkWithSection = parser.parse(
+        getRandomURI(),
+        `[link](to/path.md#section)`
+      ).links[0];
+      const linkWithSectionEdit = MarkdownLink.createUpdateLinkEdit(
+        linkWithSection,
+        {
+          type: 'wikilink',
+        }
+      );
+      expect(linkWithSectionEdit.newText).toEqual(
+        `[[to/path.md#section|link]]`
+      );
+      expect(linkWithSectionEdit.range).toEqual(linkWithSection.range);
+    });
+
+    it('should use alias in the wikilik the if there has one', () => {
+      const wikilink = parser.parse(
+        getRandomURI(),
+        `[[wikilink#section|alias]]`
+      ).links[0];
+      const wikilinkEdit = MarkdownLink.createUpdateLinkEdit(wikilink, {
+        type: 'link',
+      });
+      expect(wikilinkEdit.newText).toEqual(`[alias](wikilink#section)`);
+      expect(wikilinkEdit.range).toEqual(wikilink.range);
+    });
+  });
+
+  describe('convert to its original type', () => {
+    it('should remaind unchanged', () => {
+      const link = parser.parse(getRandomURI(), `[link](to/path.md#section)`)
+        .links[0];
+      const linkEdit = MarkdownLink.createUpdateLinkEdit(link, {
+        type: 'link',
+      });
+      expect(linkEdit.newText).toEqual(`[link](to/path.md#section)`);
+      expect(linkEdit.range).toEqual(link.range);
+
+      const wikilink = parser.parse(
+        getRandomURI(),
+        `[[wikilink#section|alias]]`
+      ).links[0];
+      const wikilinkEdit = MarkdownLink.createUpdateLinkEdit(wikilink, {
+        type: 'wikilink',
+      });
+      expect(wikilinkEdit.newText).toEqual(`[[wikilink#section|alias]]`);
+      expect(wikilinkEdit.range).toEqual(wikilink.range);
+    });
+  });
+
+  describe('change isEmbed property', () => {
+    it('should change isEmbed only', () => {
+      const wikilink = parser.parse(getRandomURI(), `[[wikilink]]`).links[0];
+      const wikilinkEdit = MarkdownLink.createUpdateLinkEdit(wikilink, {
+        isEmbed: true,
+      });
+      expect(wikilinkEdit.newText).toEqual(`![[wikilink]]`);
+      expect(wikilinkEdit.range).toEqual(wikilink.range);
+
+      const link = parser.parse(getRandomURI(), `![link](to/path.md)`).links[0];
+      const linkEdit = MarkdownLink.createUpdateLinkEdit(link, {
+        isEmbed: false,
+      });
+      expect(linkEdit.newText).toEqual(`[link](to/path.md)`);
+      expect(linkEdit.range).toEqual(link.range);
+    });
+
+    it('should be unchanged if the update value is the same as the original one', () => {
+      const embeddedWikilink = parser.parse(getRandomURI(), `![[wikilink]]`)
+        .links[0];
+      const embeddedWikilinkEdit = MarkdownLink.createUpdateLinkEdit(
+        embeddedWikilink,
+        {
+          isEmbed: true,
+        }
+      );
+      expect(embeddedWikilinkEdit.newText).toEqual(`![[wikilink]]`);
+      expect(embeddedWikilinkEdit.range).toEqual(embeddedWikilink.range);
+
+      const link = parser.parse(getRandomURI(), `[link](to/path.md)`).links[0];
+      const linkEdit = MarkdownLink.createUpdateLinkEdit(link, {
+        isEmbed: false,
+      });
+      expect(linkEdit.newText).toEqual(`[link](to/path.md)`);
+      expect(linkEdit.range).toEqual(link.range);
+    });
+  });
 });

From 1daf3bef61bc6fc8b62ff197a3fea24b60493c96 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 30 Jun 2024 16:21:27 +0800
Subject: [PATCH 18/23] follow prettier format

---
 packages/foam-vscode/src/core/janitor/convert-links-format.ts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index df9407573..ae4f433be 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -73,8 +73,7 @@ export function convertLinkFormat(
     }
 
     /* if it's originally an embedded note, the markdown link shouldn't be embedded */
-    const isEmbed =
-      targetRes.type === 'image' ? link.isEmbed : false;
+    const isEmbed = targetRes.type === 'image' ? link.isEmbed : false;
 
     return MarkdownLink.createUpdateLinkEdit(link, {
       alias: alias,

From aaa8321a361061e0afe36dd09fbb1b209f2bab21 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 30 Jun 2024 16:53:41 +0800
Subject: [PATCH 19/23] change to one line expression

---
 packages/foam-vscode/src/core/services/markdown-link.ts | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/packages/foam-vscode/src/core/services/markdown-link.ts b/packages/foam-vscode/src/core/services/markdown-link.ts
index ab273c703..b0ba35e16 100644
--- a/packages/foam-vscode/src/core/services/markdown-link.ts
+++ b/packages/foam-vscode/src/core/services/markdown-link.ts
@@ -52,12 +52,7 @@ export abstract class MarkdownLink {
     const newAlias = delta.alias ?? alias ?? '';
     const sectionDivider = newSection ? '#' : '';
     const aliasDivider = newAlias ? '|' : '';
-    const embed = (() => {
-      if (typeof delta.isEmbed === 'boolean') {
-        return delta.isEmbed ? '!' : '';
-      }
-      return link.isEmbed ? '!' : '';
-    })();
+    const embed = delta.isEmbed ?? link.isEmbed ? '!' : '';
     const type = delta.type ?? link.type;
     if (type === 'wikilink') {
       return {

From bdfa6768b33e8868a6a944cc671599d188d7bb8a Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Mon, 1 Jul 2024 11:15:10 +0800
Subject: [PATCH 20/23] get target from getIdentifier

---
 .../foam-vscode/src/core/janitor/convert-links-format.ts   | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/packages/foam-vscode/src/core/janitor/convert-links-format.ts b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
index ae4f433be..c85e0adc8 100644
--- a/packages/foam-vscode/src/core/janitor/convert-links-format.ts
+++ b/packages/foam-vscode/src/core/janitor/convert-links-format.ts
@@ -51,13 +51,8 @@ export function convertLinkFormat(
   let relativeUri = targetRes.uri.relativeTo(resource.uri.getDirectory());
 
   if (targetFormat === 'wikilink') {
-    /* remove extension if possible, then get the basename to prevent from filename conflict */
-    if (relativeUri.path.endsWith(workspace.defaultExtension)) {
-      relativeUri = relativeUri.changeExtension('*', '');
-    }
-
     return MarkdownLink.createUpdateLinkEdit(link, {
-      target: relativeUri.getBasename(),
+      target: workspace.getIdentifier(relativeUri),
       type: 'wikilink',
     });
   }

From 7af316b0691fdc64ae652f1d8f4122f80f562657 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Tue, 2 Jul 2024 23:33:34 +0800
Subject: [PATCH 21/23] add tests for inserting angles

---
 .../src/core/services/markdown-link.test.ts   | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/packages/foam-vscode/src/core/services/markdown-link.test.ts b/packages/foam-vscode/src/core/services/markdown-link.test.ts
index e2626ffb6..b49f7cafc 100644
--- a/packages/foam-vscode/src/core/services/markdown-link.test.ts
+++ b/packages/foam-vscode/src/core/services/markdown-link.test.ts
@@ -390,4 +390,49 @@ describe('MarkdownLink', () => {
       expect(linkEdit.range).toEqual(link.range);
     });
   });
+
+  describe('insert angles', () => {
+    it('should insert angles when meeting space in links', () => {
+      const link = parser.parse(getRandomURI(), `![link](to/path.md)`).links[0];
+      const linkAddSection = MarkdownLink.createUpdateLinkEdit(link, {
+        section: 'one section',
+      });
+      expect(linkAddSection.newText).toEqual(
+        `![link](<to/path.md#one section>)`
+      );
+      expect(linkAddSection.range).toEqual(link.range);
+
+      const linkChangingTarget = parser.parse(
+        getRandomURI(),
+        `[link](to/path.md#one-section)`
+      ).links[0];
+      const linkEdit = MarkdownLink.createUpdateLinkEdit(linkChangingTarget, {
+        target: 'to/another path.md',
+      });
+      expect(linkEdit.newText).toEqual(
+        `[link](<to/another path.md#one-section>)`
+      );
+      expect(linkEdit.range).toEqual(linkChangingTarget.range);
+
+      const wikilink = parser.parse(getRandomURI(), `[[wikilink#one section]]`)
+        .links[0];
+      const wikilinkEdit = MarkdownLink.createUpdateLinkEdit(wikilink, {
+        type: 'link',
+      });
+      expect(wikilinkEdit.newText).toEqual(
+        `[wikilink#one section](<wikilink#one section>)`
+      );
+      expect(wikilinkEdit.range).toEqual(wikilink.range);
+    });
+
+    it('should not insert angles in wikilink', () => {
+      const wikilink = parser.parse(getRandomURI(), `[[wikilink#one section]]`)
+        .links[0];
+      const wikilinkEdit = MarkdownLink.createUpdateLinkEdit(wikilink, {
+        target: 'another wikilink',
+      });
+      expect(wikilinkEdit.newText).toEqual(`[[another wikilink#one section]]`);
+      expect(wikilinkEdit.range).toEqual(wikilink.range);
+    });
+  });
 });

From b9775a3a1a2a18b13e29e0ecaf231e7784860f1d Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 7 Jul 2024 00:01:16 +0800
Subject: [PATCH 22/23] fix typo

---
 packages/foam-vscode/src/core/services/markdown-link.test.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/foam-vscode/src/core/services/markdown-link.test.ts b/packages/foam-vscode/src/core/services/markdown-link.test.ts
index b49f7cafc..b81efed1b 100644
--- a/packages/foam-vscode/src/core/services/markdown-link.test.ts
+++ b/packages/foam-vscode/src/core/services/markdown-link.test.ts
@@ -332,7 +332,7 @@ describe('MarkdownLink', () => {
   });
 
   describe('convert to its original type', () => {
-    it('should remaind unchanged', () => {
+    it('should remain unchanged', () => {
       const link = parser.parse(getRandomURI(), `[link](to/path.md#section)`)
         .links[0];
       const linkEdit = MarkdownLink.createUpdateLinkEdit(link, {

From 866a09102a9b3a9ea3e3882cd968f8a636e5f036 Mon Sep 17 00:00:00 2001
From: XinglanL <xinglanliu41@gmail.com>
Date: Sun, 7 Jul 2024 13:06:33 +0800
Subject: [PATCH 23/23] change require to import statement

---
 .../src/features/commands/convert-links-format-in-note.ts  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
index e2c652ce0..1e2bd5c84 100644
--- a/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
+++ b/packages/foam-vscode/src/features/commands/convert-links-format-in-note.ts
@@ -1,4 +1,4 @@
-import { commands, ExtensionContext, window } from 'vscode';
+import { commands, ExtensionContext, window, workspace, Uri } from 'vscode';
 import { isMdEditor } from '../../utils';
 import { Foam } from '../../core/model/foam';
 import { FoamWorkspace } from '../../core/model/workspace';
@@ -6,7 +6,6 @@ import { fromVsCodeUri, toVsCodeRange } from '../../utils/vsc-utils';
 import { ResourceParser } from '../../core/model/note';
 import { IMatcher } from '../../core/services/datastore';
 import { convertLinkFormat } from '../../core/janitor';
-const vscode = require('vscode'); /* cannot import workspace from above statement and not sure what happened */
 
 type LinkFormat = 'wikilink' | 'link';
 
@@ -176,13 +175,13 @@ async function convertLinkInCopy(
   const resource = fParser.parse(fromVsCodeUri(doc.uri), text);
   const basePath = doc.uri.path.split('/').slice(0, -1).join('/');
 
-  const fileUri = vscode.Uri.file(
+  const fileUri = Uri.file(
     `${
       basePath ? basePath + '/' : ''
     }${resource.uri.getName()}.copy${resource.uri.getExtension()}`
   );
   const encoder = new TextEncoder();
-  await vscode.workspace.fs.writeFile(fileUri, encoder.encode(text));
+  await workspace.fs.writeFile(fileUri, encoder.encode(text));
   await window.showTextDocument(fileUri);
 
   await convertLinkInPlace(fWorkspace, fParser, fMatcher, convertOption);