Modal closes automatically when switching to first or last icon page with button

[GuentherK]

First i would like to thank you for your effort creating this package.

We have the issue that the icon picker modal closes automatically when you switch vom the 2nd page to the first page or when you switch from the length -1 to last page.

How to reproduce this issue:

just open the icon picker from your demo page
https://fonticonpicker.github.io/react-fonticonpicker/examples/

this is very problematic if you have only 2 pages. E.g on your demo page the 'implied search' example with the 'Web Application Icons' filter

[obrejla]

Hi @Greg-mso ! Would it be possible to release a new version with this fix? It's quite annoying preventing us to actually use it, so it would be really great :) Thanks a lot for your work!

[Greg-G23]

Hi @obrejla , it was merged into master by @swashata on 5th Jan this year. You should be able to update to the latest version and see the fix.

[obrejla]

@Greg-mso Unfortunately, there is version 1.2.0 on npm - https://www.npmjs.com/package/@fonticonpicker/react-fonticonpicker More than year old.

[Greg-G23]

@obrejla Afraid I don't have permission to do so, however you could update your package.json to use '/fontIconPicker/react-fonticonpicker#master' and it should pick up those merged changes. Hope that helps.

[obrejla]

Hi @Greg-mso , imho if @swashata is the main maintainer, then he could do the regular publish of new fixed version? @swashata , what do you think? Thanks.

[swashata]

Hi all, the thing is there are lots of errors in the repo right now, because when I made it, I didn't have proper understanding of react (and the life cycles). I intend to rewrite this whole thing with hooks. Till then you can fork, build and use your own version of the whole thing. I am sorry I don't have the time budget right now, but I will try to in a couple of months.

[gregfenton]

/fontIconPicker/react-fonticonpicker#master

@obrejla Afraid I don't have permission to do so, however you could update your package.json to use '/fontIconPicker/react-fonticonpicker#master' and it should pick up those merged changes. Hope that helps.

@Greg-mso - can you show an example of what your package.json line looks like to pick up #master ?

[anisayari]

Anything new with this issue? I have the same issue :(. The panel close when I click to the next or previous page...