Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that vm.expectRevert should not be used for low-level calls #820

Open
PaulRBerg opened this issue Feb 17, 2023 · 1 comment
Open

Document that vm.expectRevert should not be used for low-level calls #820

PaulRBerg opened this issue Feb 17, 2023 · 1 comment
Labels
good first issue Good for newcomers T-enhancement Type: enhance existing docs

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Feb 17, 2023 •
edited
Loading

As discussed in foundry-rs/foundry#1124, and foundry-rs/foundry#3901 (comment).
@PaulRBerg
Copy link
Contributor Author

As @mds1 said in this comment:

If so, then maybe the best path forward here is leaving as-is and updating the foundry book to mention you must assert on the return status for expectRevert work as expected for low-level calls

@Evalir Evalir mentioned this issue Jul 4, 2023
Open
9 tasks
@zerosnacks zerosnacks added T-enhancement Type: enhance existing docs good first issue Good for newcomers labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers T-enhancement Type: enhance existing docs
Projects
No open projects
Foundry Book
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulRBerg @zerosnacks