Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source.ast.absolute_path is not an absolute path #9

Open
odyslam opened this issue Oct 27, 2023 · 1 comment
Open

source.ast.absolute_path is not an absolute path #9

odyslam opened this issue Oct 27, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@odyslam
Copy link

odyslam commented Oct 27, 2023

This was surfaced in foundry.

The absolute_path is not absolute, but it's the relative path (e.g KillProtocol.s.sol). The fs_read will fail, unless forge script runs from the directory in which the project lives.

Maybe it should change it's name to relative_path and then append it in relation to the root in forge?

@1010adigupta
Copy link

i would like to take this

@odyslam odyslam closed this as completed Dec 2, 2023
@odyslam odyslam reopened this Dec 2, 2023
@zerosnacks zerosnacks added this to the v1.0.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants