Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gRPC between frontend and APIs #29

Closed
frouioui opened this issue Nov 27, 2020 · 0 comments · Fixed by #50
Closed

Use gRPC between frontend and APIs #29

frouioui opened this issue Nov 27, 2020 · 0 comments · Fixed by #50
Labels
api Related to the system's APIs good first issue Good for newcomers gRPC Everything related to gRPC performance Everything relating to performance improvement or issue

Comments

@frouioui
Copy link
Owner

The frontend service currently uses HTTP to communicate with the APIs users and articles, however they both implement gRPC endpoints.

One of the issue in the required design to fix this issue is the sharing of the protobuf files. They could either be duplicated, put in a separated go module that we import, or separated git module.
@frouioui frouioui added good first issue Good for newcomers api Related to the system's APIs gRPC Everything related to gRPC labels Nov 27, 2020
@frouioui frouioui added the performance Everything relating to performance improvement or issue label Dec 8, 2020
@frouioui frouioui mentioned this issue Jan 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Related to the system's APIs good first issue Good for newcomers gRPC Everything related to gRPC performance Everything relating to performance improvement or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Completion of the gRPC integration frouioui/tagenal
1 participant
@frouioui