Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback-second-version #11

Open
claudia-mcosta opened this issue Feb 9, 2024 · 0 comments
Open

feedback-second-version #11

claudia-mcosta opened this issue Feb 9, 2024 · 0 comments

Comments

@claudia-mcosta
Copy link

You made a lot of fun additions and did a good job implementing the suggestions of our previous feedback.

It's great to see you implement the Factory design pattern but your obstacle creation logic can be more encapsulated. Think about what you have to change if you want to add another obstacle to your game and consider restricting the obstacle creation logic to the factory.

Focus on separating responsibilities and delegating behavior so your classes are not overburdened. Also rethink your class dependencies. Having more independent classes and behaviors will make your code more organized and easier to maintain or add to.

The Obstacle superclass is a good addition so take advantage of it by moving shared behavior to this superclass. This will help you to keep the subclasses more consistent and to write less code when you want to change behavior or add more obstacles. Also rethink the methods your interfaces are forcing these subclasses to implement.

To help you add new obstacles in the future, consider implementing the Strategy design pattern to deal with the different collision behaviors.

Consider removing unused classes. If you are working on new features with these classes, create a new branch in your repo to work on them without polluting the main branch.

I hope you are very proud of the game you created and continue to work on it in the future. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant