Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken webhooks in 24.2 #19572

Open
neoformit opened this issue Feb 10, 2025 · 0 comments
Open

Broken webhooks in 24.2 #19572

neoformit opened this issue Feb 10, 2025 · 0 comments

Comments

@neoformit
Copy link
Collaborator

Describe the bug

It seems that the new masthead in 24.2 has broken some features of webhook plugins.
JavaScript that used to work now seems to be broken - even an alert('HELLO WORLD') does not work in most cases.
The GTN plugin is not affected by this - it seems to have been written for compatibility with Vue.

This seems to affect webhooks that use the function property in config.yml, or those that rely on document $(document).ready. My suspicion is that the document is not actually ready, because Vue is still rendering something. I seem to be able to work around this by using a setTimeout to call my entrypoint.

Galaxy Version and/or server at which you observed the bug
Commit: release_24.2

Browser and Operating System
Operating System: Linux
Browser: Chrome

To Reproduce
Steps to reproduce the behavior:

  1. Checkout branch release_24.2
  2. Enable the tool_list demo webhook by copying ./config/plugins/webhooks/demo/tool_list/ to ./config/plugins/webhooks/
  3. run.sh and open in the browser
  4. Click on the "Tool list" masthead icon - the first thing that happens is an alert() but even that does not appear in my browser. There are no error messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants