Making a history private does not work (as documented)

[bernt-matthias]

Describe the bug

When users make a history private the following message is shown:

This will make all the data in this history private (excluding library datasets), and will set permissions such that all new data is created as private. Any datasets within that are currently shared will need to be re-shared or published. Are you sure you want to do this?

The italic parts seem not to work, i.e. data that has been shared previously is still accessible and only new data is private:

Screencast.from.2025-02-13.11-42-50.webm

I think the documented behavior would be good to have - otherwise it will be impossible to relocate data to a private object store.

Galaxy Version and/or server at which you observed the bug
Galaxy Version: at least 24.1 and 24.2

To Reproduce
Steps to reproduce the behavior:

1. Create history with content
2. Share the history (and copy link)
3. Make history private
4. Access import link from private session

Expectation

• Sharing link should become invalid or datasets should be shown as non-accessible (as for new datasets that are created after making the history private)
• It might be nice to better document that data that has been imported is a copy and access can not be removed anymore.

Additional context
Add any other context about the problem here.

[nsoranzo]

The sentence seems quite contradictory indeed.

[mvdbeek]

• Sharing link should become invalid or datasets should be shown as non-accessible (as for new datasets that are created after making the history private)

That is the case locally, all datasets do become private for me. Is there anything special about these datasets ?

[bernt-matthias]

Not that I know of. I also retried with a fresh history on usegalaxy.eu.

Another thing that I noted in the history menu: is that if one clicks Make private then the default permissions for new datasets are not updated (i.e Set permissions - Make new datasets private remains disabled).

[mvdbeek]

There's definitely a bug in that if you have imported a public history, and then make the datasets private only your own datasets become private.

There's a "maybe" bug as well in that you would expect that the Make Private button would also alter the accessible state of the history.