Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👩‍🌾 Set LD_LIBRARY_PATH on Actions CI (fix user_commands test) #650

Merged
merged 1 commit into from
Feb 25, 2021
Merged

👩‍🌾 Set LD_LIBRARY_PATH on Actions CI (fix user_commands test) #650

merged 1 commit into from
Feb 25, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Fixes #634 on GitHub actions (possibly on Homebrew too?)

Summary

The test failures on GitHub actions print:

Error while loading the library [/usr/local/lib/ign-gazebo-5/plugins/libignition-gazebo-sensors-system.so]: libignition-gazebo5-rendering.so.5: cannot open shared object file: No such file or directory
  [Err] [SystemLoader.cc:75] Failed to load system plugin [ignition-gazebo-sensors-system] : couldn't load library on path [/usr/local/lib/ign-gazebo-5/plugins/libignition-gazebo-sensors-system.so].

So it looks like all it needs is the path to where that is installed. I'm not sure why that hasn't come up before with other tests.

I also took the opportunity to increase the required SDF 10 version, which is needed since #636

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

https://github.com/osrf/buildfarmer/issues/161

@chapulina chapulina added the tests Broken or missing tests / testing infra label Feb 25, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 25, 2021
@chapulina chapulina mentioned this pull request Feb 25, 2021
Open
@chapulina chapulina changed the title 👩‍🌾 Set LD_LIBRARY_PATH on Actions CI (fix user_commands test) 👩‍🌾 Set LD_LIBRARY_PATH on Actions CI (fix user_commands test) Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021 •
edited
Loading

Codecov Report

Merging #650 (6fc7ad5) into ign-gazebo4 (302f5ed) will decrease coverage by 12.60%.
The diff coverage is 56.79%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo4     #650       +/-   ##
================================================
- Coverage        77.37%   64.77%   -12.61%     
================================================
  Files              217      232       +15     
  Lines            12217    16562     +4345     
================================================
+ Hits              9453    10728     +1275     
- Misses            2764     5834     +3070
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/rendering/SceneManager.hh 100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc 6.11% <0.00%> (-2.50%) ⬇️
.../plugins/component_inspector/ComponentInspector.hh 28.57% <ø> (ø)
src/gui/plugins/scene3d/Scene3D.cc 8.72% <0.00%> (ø)
src/systems/sensors/Sensors.cc 74.75% <0.00%> (ø)
src/rendering/SceneManager.cc 22.92% <8.79%> (ø)
src/systems/joint_controller/JointController.cc 77.17% <12.50%> (-6.16%) ⬇️
...int_position_controller/JointPositionController.cc 71.29% <12.50%> (-4.71%) ⬇️
src/systems/user_commands/UserCommands.cc 68.57% <35.64%> (-11.09%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d253d81...6fc7ad5. Read the comment docs.

ahcorde
ahcorde approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is still failing on MacOS https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-homebrew-amd64/5088/

@chapulina chapulina enabled auto-merge (squash) February 25, 2021 18:11
@chapulina chapulina disabled auto-merge February 25, 2021 18:11
@chapulina chapulina merged commit 3702dc8 into ign-gazebo4 Feb 25, 2021
@chapulina chapulina deleted the chapulina/4/634 branch February 25, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome tests Broken or missing tests / testing infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User command light test failure
2 participants
@chapulina @ahcorde