Improve DarkTheme

[paveldedik]

Motivation

The dark theme is not used anywhere and what it looks like is not validated. It would be nice to make it look good and validate readability on all devices.

Hints

Allow switching the theme in https://github.com/paveldedik/ludic-web and improve styling according to that.

[robwalton]

The background colour stays white when using the dark theme for me.

I switch to the dark mode as describe in the doc:

dark = themes.DarkTheme()
themes.set_default_theme(dark)

style.load(theme=dark). # <-- may not be needed


@asynccontextmanager
async def lifespan(_: LudicApp) -> AsyncIterator[None]:
    style.load(cache=True)
    yield


app = LudicApp(
    debug=True,
    lifespan=lifespan,
    routes=[Mount("/static", StaticFiles(directory="static"), name="static")],
)

And then followed the instructions here: https://getludic.dev/catalog/#htmlpage-component . However the background is still white. Am I doing it right please?

(I'm really enjoying ludic. Thanks for making it!)

[paveldedik]

Thank you for reporting the issue.

You are doing it right. There was a missing CSS for the dark theme to change background. Sorry. I just released new version fixing that.

And you are right, the third line with style.load(theme=dark) is not needed, the first two lines already take care of the theme switching.

I'm glad you are enjoying Ludic :-)

[robwalton]

The new version looks great now, thanks.