fix: fixed AutoMinorVersionUpgrade and TransitEncryptionEnabled argument issue #8641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent issue. For create_cache_cluster function passing AutoMinorVersionUpgrade or TransitEncryptionEnabled had no effect and the result always contained "False". This PR fixes that issue and updates unit test to validate the updated behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8641 +/- ##
=======================================
Coverage 92.73% 92.74%
=======================================
Files 1251 1251
Lines 108362 108442 +80
=======================================
+ Hits 100492 100573 +81
+ Misses 7870 7869 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
create_cache_clusterfunction passingAutoMinorVersionUpgradeorTransitEncryptionEnabledhad no effect and the result always containedFalse. This PR fixes that issue and updates unit test to validate the updated behaviour.Fixes #8636