Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if we still need _werkzeug.py #3516

Open
antonpirker opened this issue Sep 11, 2024 · 0 comments
Open

Check if we still need _werkzeug.py #3516

antonpirker opened this issue Sep 11, 2024 · 0 comments
Labels
Component: SDK Core Dealing with the core of the SDK Component: Tests Dealing with tests Enhancement New feature or request

Comments

@antonpirker
Copy link
Member

The file _werkzeug.py contains some vendored in code from very old versions of werkzeug.

Please check:

  • Is this code used anywhere (I guess so)
  • Can we update the code to newer code from Werkzeug?

Also make sure this code is tested to have a high test coverage. (maybe by vendoring in the related tests from Werkzeug?)
@antonpirker antonpirker added Component: SDK Core Dealing with the core of the SDK Component: Tests Dealing with tests Enhancement New feature or request labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: SDK Core Dealing with the core of the SDK Component: Tests Dealing with tests Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antonpirker