Configure HTTP methods to capture in ASGI middleware and frameworks #3533
Conversation
antonpirker
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## antonpirker/http_methods_to_capture #3533 +/- ##
=======================================================================
- Coverage 84.30% 84.29% -0.01%
=======================================================================
Files 133 133
Lines 13902 13914 +12
Branches 2933 2936 +3
=======================================================================
+ Hits 11720 11729 +9
Misses 1444 1444
- Partials 738 741 +3
|
| if transaction is not None: | ||
| is_http_response = ( | ||
| event.get("type") == "http.response.start" | ||
| and "status" in event | ||
| ) | ||
| if is_http_response: | ||
| transaction.set_http_status(event["status"]) |
There was a problem hiding this comment.
I did it this way to make mypy happy
There was a problem hiding this comment.
mypy also made me do things I'm not proud of. We need mypy anonymous
| @@ -15,6 +15,19 @@ | |||
| from sentry_sdk.utils import AnnotatedValue | |||
|
|
|||
|
|
|||
| DEFAULT_HTTP_METHODS_TO_CAPTURE = ( | |||
There was a problem hiding this comment.
Should we maybe just import this from _wsgi_common here? Or directly use the _wsgi_common constant in the integrations?
| # This noop context manager can be replaced with "from contextlib import nullcontext" when we drop Python 3.6 support | ||
| @contextmanager | ||
| def nullcontext(): | ||
| # type: () -> Iterator[None] | ||
| yield |
There was a problem hiding this comment.
Maybe move this to utils.py and use it from there? Also for wsgi.py
| if transaction is not None: | ||
| is_http_response = ( | ||
| event.get("type") == "http.response.start" | ||
| and "status" in event | ||
| ) | ||
| if is_http_response: | ||
| transaction.set_http_status(event["status"]) |
There was a problem hiding this comment.
mypy also made me do things I'm not proud of. We need mypy anonymous
antonpirker
changed the base branch from
master
to
antonpirker/http_methods_to_capture
antonpirker
merged commit 8944047
into
antonpirker/http_methods_to_capture
|
I have merge this PR into #3531 and did the de-duping in the other PR. |
OPTIONSandHEADHTTP methods by default.http_methods_to_captureconfig option for Starlette and FastAPI, to specify what HTTP methods to capture.Fixes #3529
Docs PR:
getsentry/sentry-docs#11349