Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AioHttp failed_request_status_codes #3535

Closed
Tracked by #3134
szokeasaurusrex opened this issue Sep 13, 2024 · 0 comments · Fixed by #3551
Closed
Tracked by #3134

AioHttp failed_request_status_codes #3535

szokeasaurusrex opened this issue Sep 13, 2024 · 0 comments · Fixed by #3551
Assignees
@szokeasaurusrex

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Sep 13, 2024 •
edited
Loading

For AioHttp, the failed_request_status_codes will control whether responses of certain status codes should be reported to Sentry. Regardless of how failed_request_status_codes is set, we will always report any unhandled exceptions where the response status is unclear to Sentry (this includes all unhandled exceptions, besides HTTPException, asyncio.CancelledError, and ConnectionResetError, which typically result in 500 errors, but are not guaranteed to).
@szokeasaurusrex szokeasaurusrex mentioned this issue Sep 13, 2024
Open
12 tasks
@szokeasaurusrex szokeasaurusrex changed the title AIOHTTP AioHttp failed_request_status_codes Sep 13, 2024
@szokeasaurusrex szokeasaurusrex self-assigned this Sep 13, 2024
szokeasaurusrex added a commit that referenced this issue Sep 20, 2024
@szokeasaurusrex
feat(aiohttp): Add failed_request_status_codes
2adb74e 
`failed_request_status_codes` allows users to specify the status codes, whose corresponding `HTTPException` types, should be reported to Sentry. By default, these include 5xx statuses, which is a change from the previous default behavior, where no `HTTPException`s would be reported to Sentry.

Closes #3535
@szokeasaurusrex szokeasaurusrex mentioned this issue Sep 20, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Sep 20, 2024
@szokeasaurusrex
feat(aiohttp): Add failed_request_status_codes
3ad9fa9 
`failed_request_status_codes` allows users to specify the status codes, whose corresponding `HTTPException` types, should be reported to Sentry. By default, these include 5xx statuses, which is a change from the previous default behavior, where no `HTTPException`s would be reported to Sentry.

Closes #3535
szokeasaurusrex added a commit that referenced this issue Sep 20, 2024
@szokeasaurusrex
feat(aiohttp): Add failed_request_status_codes
4558c9a 
`failed_request_status_codes` allows users to specify the status codes, whose corresponding `HTTPException` types, should be reported to Sentry. By default, these include 5xx statuses, which is a change from the previous default behavior, where no `HTTPException`s would be reported to Sentry.

Closes #3535
szokeasaurusrex added a commit that referenced this issue Sep 23, 2024
@szokeasaurusrex
feat(aiohttp): Add failed_request_status_codes
87e4a7e 
`failed_request_status_codes` allows users to specify the status codes, whose corresponding `HTTPException` types, should be reported to Sentry. By default, these include 5xx statuses, which is a change from the previous default behavior, where no `HTTPException`s would be reported to Sentry.

Closes #3535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aiohttp): Add failed_request_status_codes getsentry/sentry-python
1 participant
@szokeasaurusrex