Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support selection foreground being cell foreground #2685

Open
mitchellh opened this issue Nov 15, 2024 · 2 comments · May be fixed by #5219
Open

Support selection foreground being cell foreground #2685

mitchellh opened this issue Nov 15, 2024 · 2 comments · May be fixed by #5219
Labels
contributor friendly A well-scoped, approachable issue for someone looking to contributor.

Comments

@mitchellh
Copy link
Contributor

From #2656

Unlike #2656, the final approach I am going to suggest for this is to change selection-foreground to a tagged union in Zig and take some additional types. As part of this, I also propose removing selection-invert-fg-bg (cc @gpanders) and making it part of that union. Proposal:

# default
selection-foreground = window-background

# discussion 2656
selection-foreground = cell-foreground

# explicit color
selection-foreground = ABC123

# replacing selection-invert-fg-bg
selection-foreground = cell-background
selection-background = cell-foreground
@mitchellh mitchellh added the contributor friendly A well-scoped, approachable issue for someone looking to contributor. label Nov 15, 2024
@echasnovski
Copy link
Collaborator

Maybe the same overhaul can be made for cursor color?

So instead of cursor-color and cursor-invert-fg-bg it can be cursor-foreground and cursor-background with the same semantics as selection-foreground and selection-background?

@dmehala
Copy link
Collaborator

dmehala commented Dec 23, 2024

Hey,

I’d like to work on this issue if that’s okay. To ensure I fully understand the expected outcome, I noticed the title mentions foreground selection, but your proposal also references selection-background. Should the change involve modifying selection-background to support the new tagged union? Also, should we replicate this for cursor color?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor friendly A well-scoped, approachable issue for someone looking to contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants