-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draw octants directly rather than relying on font #5433
Conversation
a25ac8b
to
659e715
Compare
hrmmm, do the builtin draws only run when we can't find these glyphs in the font? that would explain things. i'd suggest giving them primacy should that be the case, but can understand going the other way. |
659e715
to
ea1299d
Compare
Take a look at this. There are a couple of places in |
got it, much appreciated |
d58e04d
to
fafeb49
Compare
Apologies for the delay, I plan to get this in for 1.1.1 (tagged with that milestone) and will review and modify soon. |
fafeb49
to
ef64471
Compare
ef64471
to
f3a19fd
Compare
f3a19fd
to
8b2f9ac
Compare
Alright, updated it to autogenerate the table @dankamongmen made from a text file (at comptime) that is just a copy & paste from the symbols for legacy computing supplement. If we can replace that with a mathematical formula in the future, great. If not, I like this better than the hand-made table. This is also all covered by our diffing unit test (as shown above) so any refactors in the future can ensure pixel-perfect matching is retained. Once unit tests pass will merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yQuads()
anddraw_octant()
, pretty obvious extensions of existing code. to allocate up to 3 potential remainder lines, consider that octants will often appear in a rectangular subset of the terminal. we want the distributed excess uniformly distributed across such a region. so:Octant
s are octary arrays ofbool
, provided as a somewhat opaque constant tableOctant
is not the prettiest thing in the known universedraw_sextant()
anddraw_octant()
like notcurses did, almost certainlywith that said, i don't think
draw_octant()
is actually being called lol, so let's not merge this yet. happy to hear early feedback, though.