Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to save a Reddit tab causes the tab to freeze and crash. #1437

Open
Starfire202 opened this issue Apr 14, 2024 · 8 comments
Open

Comments

@Starfire202
Copy link

Whenever I attempt to save Reddit posts (using this one), after clicking on all the spoilers, I attempt to run the extension. It manages frame contents, but at deferrered images it'll start to freeze, and at step 1/3 it will crash. This repeats every time.

Expected behavior is that it should go through normally.

This is a screen recording of me attempting to save the tab:
https://github.com/gildas-lormeau/SingleFile/assets/156129444/dbb0d2c0-b12e-4629-8d2e-5ecd70ea60c9

  • OS: MacOS Ventura 13.0
  • Browser: Chrome
  • Version: Version 123.0.6312.107 (Official Build) (arm64)
@gildas-lormeau
Copy link
Owner

I suspect it's related to #1387. This might be also exacerbated by another extension you use.

@Starfire202
Copy link
Author

I tried getting ending every intensive tab I had and some extensions (besides SingleFile and the Reddit tab of course), and surprisingly it didn't freezer, but it still crashed. I'm not sure how it would be related; my Chrome can handle large downloads pretty well (keep in mind I know nothing about coding and stuff like this). The Reddit post is this btw: https://www.reddit.com/r/Parahumans/comments/gcvvlv/pho_sunday_fey_seizes_reactors_leaving_millions/?sort=old

@kupietools
Copy link

kupietools commented May 1, 2024

Came here to report the same thing. Never actually saves, just processes forever. Just happened with https://www.reddit.com/r/recruitinghell/comments/qhg5jo/this_resume_got_me_an_interview/ but seen it a few times in the last few days. Browser is Firefox 115.10.0esr

EDIT: Came here again to report this, forgot I had already left a comment a month ago. Now on FF 115.11.0esr, same issue. Gets to step 2/3 and hangs there forever, and then I can't save any other tabs, either, the whole extension is hung.

@Zireael07
Copy link

I'm on Vivaldi browser and experiencing the same. Can't save any Reddit post.

@kupietools
Copy link

kupietools commented Aug 19, 2024

Yeah, this is still tripping me up, months after first commenting on it. I love this plugin, so I hate to sound like I'm complaining, but I spend a lot of time on Reddit so this is a bit of a pain.

@Starfire202
Copy link
Author

That didn't seem to fix it.

@gildas-lormeau
Copy link
Owner

That is why the issue is not closed. Reddit's developers have gone to great lengths to make the whole thing very slow.

@gildas-lormeau
Copy link
Owner

Note however that you should be able to save some discussions, e.g. https://www.reddit.com/r/webdev/comments/1exfmwl/what_websites_do_you_visit_daily_as_a_developer/ without crashing the browser.

gildas-lormeau added a commit to gildas-lormeau/single-file-core that referenced this issue Sep 1, 2024
gildas-lormeau added a commit to gildas-lormeau/single-file-core that referenced this issue Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants