Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue capturing Github urls with browserless #35

Open
pawanpaudel93 opened this issue Jun 24, 2023 · 2 comments
Open

Issue capturing Github urls with browserless #35

pawanpaudel93 opened this issue Jun 24, 2023 · 2 comments

Comments

@pawanpaudel93
Copy link

Issue

When the Browserless endpoint is provided as a browserServer option and a GitHub URL eg. https://github.com/pawanpaudel93, single-file does not capture the URL completely, and when opening the captured webpage the webpage seems to load without CSS.

But, It works perfectly when used without browserless though.

@marsk6
Copy link

marsk6 commented Nov 27, 2023

I have the same issue with CSS.
and I find that all CSS cdn assets have CORS errors.

image

so after appending access-control-allow-origin: {originHost} and access-control-allow-credentials: true into the response header, the captured webpage can work completely.

@pawanpaudel93
Copy link
Author

@marsk6 how are you using the headers withsingle-file-cli and the captured webpage is working completely ? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants