Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an Issue or PR for repos with no CODEOWNERS file #10

Closed
zkoppert opened this issue Feb 1, 2024 · 4 comments
Closed

Create an Issue or PR for repos with no CODEOWNERS file #10

zkoppert opened this issue Feb 1, 2024 · 4 comments
Labels
enhancement New feature or request keep

Comments

@zkoppert
Copy link
Member

zkoppert commented Feb 1, 2024

No description provided.

@zkoppert zkoppert added the enhancement New feature or request label Feb 1, 2024
Copy link

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 13, 2024
@zkoppert zkoppert added keep and removed Stale labels Mar 14, 2024
@electriquo
Copy link

electriquo commented Mar 31, 2024

@zkoppert Isn't this issue a duplication of #23?

@electriquo
Copy link

electriquo commented Mar 31, 2024

In this block

if not codeowners_file_contents:
print(f"Skipping {repo.full_name} as it does not have a CODEOWNERS file")
no_codeowners_count += 1
continue
there is variable named no_codeowners_count that counts the amount of repositories without CODEOWNERS file. In this block the repo variable can be used to get the repository name without a CODEOWNERS file. The repository name can be added to a list that holds repositories without a CODEOWNERS file.

Later on, no_codeowners_count variable can be use to check whether it is greater than zero, and open an issue with the list of repositories without a CODEOWNERS file.

I suggest to always use the same issue and update/close/reopn it accordingly.

A followup question, assume there is a CODEONWERS file and it is empty. What should happen then (maybe #11)?

@zkoppert
Copy link
Member Author

zkoppert commented Apr 1, 2024

Closing as duplicate to #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep
Projects
None yet
Development

No branches or pull requests

2 participants