diff --git a/csharp/ql/src/Bad Practices/PathCombine.qhelp b/csharp/ql/src/Bad Practices/PathCombine.qhelp index 2191ffc46761..2562a615c87d 100644 --- a/csharp/ql/src/Bad Practices/PathCombine.qhelp +++ b/csharp/ql/src/Bad Practices/PathCombine.qhelp @@ -11,6 +11,8 @@ +
  • Microsoft Learn, .NET API browser, Path.Combine.
  • +
  • Microsoft Learn, .NET API browser, Path.Join.
  • diff --git a/csharp/ql/src/Bad Practices/PathCombine.ql b/csharp/ql/src/Bad Practices/PathCombine.ql index 7de1ad271e39..7363999727fd 100644 --- a/csharp/ql/src/Bad Practices/PathCombine.ql +++ b/csharp/ql/src/Bad Practices/PathCombine.ql @@ -14,4 +14,4 @@ import semmle.code.csharp.frameworks.System from MethodCall call where call.getTarget().hasFullyQualifiedName("System.IO", "Path", "Combine") -select call, "Path.Combine may silently discard its initial arguments if the latter are absolute paths. Use Path.Join to consistently join them." \ No newline at end of file +select call, "Call to System.IO.Path.Combine." diff --git a/csharp/ql/test/query-tests/Bad Practices/Path Combine/PathCombine.expected b/csharp/ql/test/query-tests/Bad Practices/Path Combine/PathCombine.expected index 07ae158d60c1..ae6b252e8733 100644 --- a/csharp/ql/test/query-tests/Bad Practices/Path Combine/PathCombine.expected +++ b/csharp/ql/test/query-tests/Bad Practices/Path Combine/PathCombine.expected @@ -1 +1 @@ -| PathCombine.cs:7:9:7:54 | call to method Combine | Path.Combine may silently discard its initial arguments if the latter are absolute paths. Use Path.Join to consistently join them. | +| PathCombine.cs:7:9:7:54 | call to method Combine | Call to System.IO.Path.Combine. |