feat: improve fingerprint and output with wildcard #1808
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaerten
force-pushed
the
feat/improve-fingerprint-with-wildcard
branch
from
feb5d44
to
dab7cb3
Compare
andreynering
reviewed
Oct 6, 2024
| @@ -447,6 +446,7 @@ func (e *Executor) GetTask(call *ast.Call) (*ast.Task, error) { | |||
| call.Vars = &ast.Vars{} | |||
| } | |||
| call.Vars.Set("MATCH", ast.Var{Value: matchingTasks[0].Wildcards}) | |||
| matchingTasks[0].Task.FullName = call.Task | |||
There was a problem hiding this comment.
It looks like we'd be getting a race condition here, no? Parallel calls to this task would be overiding the same attribute.
Tricky to implement this in another way, though, I know...
There was a problem hiding this comment.
You are totally right. The same task with a wildcard, used twice in a dep (ran in parallel) the first one will be overridden by the last
Put this in draft until I find a solution for it
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes :
It also improve the output, now the task with wildcard replaced are displayed :
I was struggled a bit with the naming. I choose
Fullnamebut feel free if you have a better idea.