Move attributes from KeeperSpec to KeeperStatus #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnaveiras
force-pushed
the
rnaveiras/keeper-spec-to-keeper-status
branch
2 times, most recently
from
81c8ef6 to
1416835
Compare
KeeperStatus is the up-to-date information about the keeper state. Since inside the keeper (using a per keeper cli option) we're specifying a specific keeper "property" and reporting this via the KeeperInfo. Then update KeeperStatus so the sentinel will use this new fields to compute the final cluster state.
rnaveiras
force-pushed
the
rnaveiras/keeper-spec-to-keeper-status
branch
from
1416835 to
5fdb8a5
Compare
dyson
approved these changes
Sep 3, 2019
|
This was manually tested and everything looked good. Going to merge and cut a new release of our fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context sorintlab#696
Follow Simone comments this PR move the keeper attributes from the KeeperSpec to the KeeperStatus