Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some commands don't work in Firefox (like "/") #174

Open
AhmadGhaemi opened this issue Apr 28, 2023 · 12 comments
Open

Some commands don't work in Firefox (like "/") #174

AhmadGhaemi opened this issue Apr 28, 2023 · 12 comments

Comments

@AhmadGhaemi
Copy link

Some commands do not work for me in Firefox, unfortunately. Neither the address bar nor the github comment - see the gifs. It seems to me like it's using the keyboard strategy, since cmd+f is triggered when pressing "/" (and for some reason full screen, might have to do with shift+cmd+f being the shortcut for fullscreen in FF but I haven’t pressed shift, so…).

Firefox github comment:

Screen Recording 2023-03-31 at 14 49 00(1)

Firefox address bar:

Screen Recording 2023-03-31 at 14 50 22(1)

Firefox accessibility.force_disabled property is set to 0:
PastedGraphic-1

@mrboen94
Copy link

I know this is probably not the fix you are looking for, but making browsers work properly is really hard afaik. I think using the vimium plugin will be much better for this, and disabling vim for firefox. Vimium is really good at both changing tabs and navigating pages. I dont know how you'd solve the text editing in firefox though.

@godbout
Copy link
Owner

godbout commented Nov 21, 2023

was wondering why i never answered this and then remember that we dealt with @AhmadGhaemi by email and this issue was me asking him to report on GitHub. but didn't get any new update by email either. so, @AhmadGhaemi, were you able to make kV work with Firefox? coz when setting the Accessibility ON, it should.

@godbout
Copy link
Owner

godbout commented Nov 21, 2023

I think using the vimium plugin will be much better for this, and disabling vim for firefox. Vimium is really good at both changing tabs and navigating pages. I dont know how you'd solve the text editing in firefox though.

but the purpose is totally different. my other app (Wooshy) does what Vimium does but for the whole macOS. but it's clicking and reaching UI Elements, not having Vim bindings in any text field and text area.

@AhmadGhaemi
Copy link
Author

@mrboen94 Thanks for the reply. I'm fine with native shortcuts for tabs anyway since I'm used to them, might try Vimium out for navigating pages if I feel the need for it.

@godbout: Our email ended with you saying you'll dig into it after the move iirc! I wasn't able to find out why it didn't work and as you see above the accessibility is on (force_disabled is false)... I also tried it set to 1 to make sure. Would you mind trying to reproduce it? I remember you saying you don't use Firefox, right?

@godbout
Copy link
Owner

godbout commented Nov 21, 2023

@AhmadGhaemi ah shit my bad sorry lol. ok, back to the todo list and will check again. i don't use Firefox personally (Safari for daily use, Brave for web dev) but i have it installed for tests so still, i need to find out what's going on here.

will investigate. for real this time. sorry hehe.

@mrboen94
Copy link

I know, but I found firefox to work better with it disabled in your plugin. Im trying it out right now, but it does take some getting used to as it kills some other workflows ive been using for years.

@godbout
Copy link
Owner

godbout commented Nov 22, 2023

I know, but I found firefox to work better with it disabled in your plugin. Im trying it out right now, but it does take some getting used to as it kills some other workflows ive been using for years.

haha change of workflow is tough. if your current one works well and the new one doesn't add anything, probably best to keep the old one 😂️

@godbout
Copy link
Owner

godbout commented Nov 25, 2023

so yeah, the macOS Accessibility is broken in Firefox. kV can read text, but when it modifies text Firefox doesn't follow the instructions. i have filed a couple of bugs in the past. filed a new one now here: https://bugzilla.mozilla.org/show_bug.cgi?id=1866621

the issue i think is that plans and schedules for FF and Mozilla stuff has changed over the years, and there hasn't been proper follow ups. nothing i can do from kV's side. FF has to comply with how the macOS AX works. i don't have much hope for it tbh.

@godbout
Copy link
Owner

godbout commented Nov 25, 2023

i'll update the description in The Wizard to advise for the Key Mapping Strategy.

@godbout
Copy link
Owner

godbout commented Nov 25, 2023

i'll update the description in The Wizard to advise for the Key Mapping Strategy.

ok actually i'm seeing that it's already the case. the last update of the description mentioned also that the writing part of the AX doesn't work. so yeah. Firefox needs to be added to the Key Mapping, and therefore you'll get some Vim motions—but not all—handled through key remapping.

@AhmadGhaemi
Copy link
Author

Alright, sorry my bad, must've missed that. That explains it. Thanks for filing the bug report.

@godbout
Copy link
Owner

godbout commented Nov 28, 2023

no worries. but yeah sorry. nothing much that i can do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants