Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

website: search box default text cut off in desktop Safari #27210

Closed
willfaught opened this issue Aug 25, 2018 · 9 comments
Closed

website: search box default text cut off in desktop Safari #27210

willfaught opened this issue Aug 25, 2018 · 9 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@willfaught
Copy link
Contributor

Sorry, not sure where to file this. https://github.com/golang/blog doesn't track issues.

screen shot 2018-08-24 at 5 56 31 pm

macOS High Sierra 10.13.6 (17G65)
MacBook Pro (Retina, 15-inch, Mid 2015)
Safari Version 11.1.2 (13605.3.8)
@agnivade agnivade changed the title golang.org: search box default text cut off in desktop Safari website: search box default text cut off in desktop Safari Aug 25, 2018
@agnivade
Copy link
Contributor

Does this happen only in a osx+safari combo ? Or in other OSes also ?

@agnivade agnivade added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 25, 2018
@agnivade agnivade added this to the Unplanned milestone Aug 25, 2018
@willfaught
Copy link
Contributor Author

willfaught commented Aug 25, 2018 via email

@andybons
Copy link
Member

andybons commented Aug 25, 2018 •
edited
Loading

Safari desktop only runs on macOS. Mobile views of the blog/golang.org don't have this problem.

@andybons andybons added help wanted NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 25, 2018
@andybons andybons modified the milestones: Unplanned, Unreleased Aug 25, 2018
@jimmyfrasche
Copy link
Member

Works in linux chrome and firefox, but I get a different computed font-family for the input in each. I'm guessing this is an issue with UA stylesheet not being overridden enough.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/131317 mentions this issue: godoc/static: adjust left and right paddings

@agnivade
Copy link
Contributor

Safari desktop only runs on macOS.

I see that they have stopped supporting it on Windows. Didn't know that.

@namusyaka
Copy link
Member

I think this issue caused by ::-webkit-search-decoration, my patch gets rid of it by specifing -webkit-appearance.

@agnivade agnivade mentioned this issue Jan 15, 2019
Closed
@agnivade
Copy link
Contributor

This seems to have appeared again (#29742) in Safari Version 12.0 (14606.1.36.1.9). Reopening.

@agnivade agnivade reopened this Jan 15, 2019
@rsc
Copy link
Contributor

rsc commented Feb 23, 2021

Search box removed (#44357).

@rsc rsc closed this as completed Feb 23, 2021
@golang golang locked and limited conversation to collaborators Feb 23, 2022
henderjon pushed a commit to oggodoc/godoc that referenced this issue Jun 13, 2024
@namusyaka @bradfitz
godoc/static: get rid of ::-webkit-search-decoration of #search
897a90f 
The input[type="search"] has a pseudo element,
it's ::-webkit-search-decoration and has an original margin.

To get rid of the margin, this commit specifies -webkit-appearance
property to none.

Fixes golang/go#27210

Change-Id: I09bbae5e0b811a3b3fa3a047b97ea45190e75f46
Reviewed-on: https://go-review.googlesource.com/c/131317
Reviewed-by: Brad Fitzpatrick <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
7 participants
@willfaught @rsc @namusyaka @andybons @jimmyfrasche @agnivade @gopherbot