Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: add opensearch.xml #43982

Closed
xfmoulet opened this issue Jan 29, 2021 · 5 comments
Closed

x/website: add opensearch.xml #43982

xfmoulet opened this issue Jan 29, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@xfmoulet
Copy link

xfmoulet commented Jan 29, 2021 •
edited
Loading

What did you do?

using Firefox, select the "add godoc" as a search engine

What did you expect to see?

golang search engine added to Firefox

What did you see instead?

https://golang.org/opensearch.xml not found

copy/pasting this url in the adrowser gives an error page:

lstat $GOROOT/opensearch.xml: no such file or directory
@gopherbot gopherbot added this to the Unreleased milestone Jan 29, 2021
@seankhliao seankhliao changed the title x/website: missing golang search engine xml file x/website: add opensearch.xml Jan 29, 2021
@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 29, 2021
@seankhliao
Copy link
Member

Is it useful for golang.org to do this or is this better suited for pkg.go.dev (which includes the docs for stdlib)?

@seankhliao
Copy link
Member

I just saw there's an opensearch file https://go.googlesource.com/website/+/refs/heads/master/content/static/opensearch.xml and it's linked via <link> tags but not served

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/290210 mentions this issue: godoc: expose opensearch

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/290230 mentions this issue: cmd/golangorg: register handler for opensearch.xml

@rsc
Copy link
Contributor

rsc commented Feb 23, 2021

Search box removed (#44357).

@rsc rsc closed this as completed Feb 23, 2021
@golang golang locked and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@rsc @gopherbot @seankhliao @xfmoulet