We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cryptobyte.String has ReadUintNLengthPrefixed for N 8, 16, and 24, but not 32, despite Builder having AddUint32LengthPrefixed.
cryptobyte.String
ReadUintNLengthPrefixed
N
Builder
AddUint32LengthPrefixed
ReadUint32LengthPrefixed would be useful for parsing SSH protocol messages, which use uint32-prefixed strings.
ReadUint32LengthPrefixed
I propose adding:
func (s *String) ReadUint32LengthPrefixed(out *String) bool
cc @rolandshoemaker @FiloSottile
The text was updated successfully, but these errors were encountered:
Sorry, something went wrong.
I implemented it two years ago https://go-review.googlesource.com/c/crypto/+/360095 but it was never reviewed. Somehow original issue link #49227 is not working atm.
No branches or pull requests
Proposal Details
cryptobyte.String
hasReadUintNLengthPrefixed
forN
8, 16, and 24, but not 32, despiteBuilder
havingAddUint32LengthPrefixed
.ReadUint32LengthPrefixed
would be useful for parsing SSH protocol messages, which use uint32-prefixed strings.I propose adding:
cc @rolandshoemaker @FiloSottile
The text was updated successfully, but these errors were encountered: