x/net/webdav: MOVE interprets lack of Overwrite header incorrectly

[caldwell]

Go version

go version go1.22.4 linux/amd64

Output of go env in your module/workspace:

not applicable

What did you do?

I'm using a client that issues a MOVE but doesn't include an Overwrite header to a Go web server that uses the x/net/webdav code.

What did you see happen?

The Go WebDAV server responds with a 412 HTTP status code and "file already exists" as the error. This is incorrect.

What did you expect to see?

I would expect to see a 200 HTTP status code and for the destination file to be overwritten.

It appears that this line of code is incorrect (google link).

It's passing true to the overwrite argument of moveFiles only if the Overwrite header is T, but the WebDAV RFC section 10.6 states:

If the overwrite header is not included in a COPY or MOVE request, then the resource MUST treat the request as if it has an overwrite header of value "T".

Interestingly, the COPY code just a few lines before checks for this correctly (google link).

[gabyhelp]

Similar Issues

• x/net/webdav: MOVE without an Overwrite header does not default to T #66059
• x/net/webdav: moving a locked file fails unless destination is locked #43556
• x/net/webdav: PUT handler does not support conditional requests using If-... headers #44492

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[prattmic]

cc @neild @ianlancetaylor

[rsc]

Looks like a duplicate of #66059?

[seankhliao]

Duplicate of #66059